New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom fields to support dynamic forms in formik #5789
Add custom fields to support dynamic forms in formik #5789
Conversation
/retest |
/assign @christianvogt |
/retest |
baa5076
to
e2182d6
Compare
/retest |
1 similar comment
/retest |
aae06e7
to
91ba110
Compare
/assign @TheRealJon This PR has some updates to the dynamic form components and utils to support new use cases. It would be great to have your review for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... only a question that confuses me. Not sure you need the AsyncComponent
.
frontend/packages/console-shared/src/components/formik-fields/DynamicFormField.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just a small comment
frontend/packages/console-shared/src/components/formik-fields/DynamicFormField.tsx
Outdated
Show resolved
Hide resolved
ef5cc0d
to
ca33206
Compare
ca33206
to
a73923b
Compare
/lgtm |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
/lgtm Forgot there's another dependent PR. Get this in and fix the mobile breakpoints in #5790 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: https://issues.redhat.com/browse/ODC-4084
Analysis / Root cause: Right now we use formik for all of our forms in dev console. Dynamic forms uses a separate framework called
json-schema-form
and it created based on kube resources and there actions. This wouldn't work for use because of formik forms and Helm resources not being kube native resources.Solution Description: In order to make use of dynamic forms in the formik context, we needed to customize the already present dynamic form components and utils to support our use case for Helm install and upgrade forms. We also needed to create bridge components which bridges formik state to dynamic form state. This PR adds support for these custom components and also customizes already present components and utils.
Screen shots / Gifs for design review:
Helm Install -
Helm Upgrade -
Unit Tests Added
Browser conformance: