New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1849148: disable addOnPaste in <SelectorInput> #5801
Conversation
Fix bug where pasted values such as `openshift.io/run-level: '1'` do not appear. Note this fix disables the ability to paste multiple values at the same time; however, the existing code assumes only one value is being added at a time, and if one of the values contains an invalid character, the entire paste fails (which is the underlying cause of the issue with a value like `openshift.io/run-level: '1'` since the space indicates more than more value).
@rhamilto: This pull request references Bugzilla bug 1849148, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rhamilto: This pull request references Bugzilla bug 1849148, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
Thanks @rhamilto. I agree this is better
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/cherry-pick release-4.5 |
@rhamilto: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@rhamilto: All pull requests linked via external trackers have merged: openshift/console#5801. Bugzilla bug 1849148 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rhamilto: new pull request created: #5809 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix bug where pasted values such as
openshift.io/run-level: '1'
do not appear. Note this fix disables the ability to paste multiple values at the same time; however, the existing code assumes only one value is being added at a time, and if one of the values contains an invalid character, the entire paste fails (which is the underlying cause of the issue with a value likeopenshift.io/run-level: '1'
since the space indicates more than more value).Bonus fix: if the entered text was invalid, set the cursor back to black if the user deletes all the entered text (was staying red).
Strings copied/pasted in the screenshots below:
openshift.io/run-level: '1'
foo bar=bam baz=bam
foo bar=bam baz=bam bam: bop
Before:
After: