Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1855811: Allow Tekton Event Listeners to render without a full route #5802

Conversation

andrewballantyne
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/ODC-4202

Analysis / Root cause:
Tried to use the partial Route object to craft a route and it failed to do so.

Solution Description:
Make sure we have a valid structured route before trying to get a URL out of it.

Test setup:

  • OpenShift Pipelines Operator
  • Go to Event Listener Create YAML and add this:
apiVersion: triggers.tekton.dev/v1alpha1
kind: EventListener
metadata:
  name: event-listener
spec:
  serviceAccountName: pipeline
  triggers:
    - bindings:
        - name: generic-git
      template:
        name: pipeline-template
  • Before this fix, on completion of the YAML it would throw the error as it had a non-exposed route object

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Jun 23, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2020
@rottencandy
Copy link
Contributor

Tested locally.
/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2020
@openshift-merge-robot openshift-merge-robot merged commit f744b20 into openshift:master Jul 6, 2020
@spadgett spadgett added this to the v4.6 milestone Jul 8, 2020
@openshift-cherrypick-robot

@andrewballantyne: #5802 failed to apply on top of branch "release-4.5":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	frontend/packages/dev-console/src/components/pipelines/utils/triggers.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/dev-console/src/components/pipelines/utils/triggers.ts
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/components/pipelines/utils/triggers.ts
Patch failed at 0001 Allow Tekton Event Listeners to render without a full route

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andrewballantyne andrewballantyne changed the title Allow Tekton Event Listeners to render without a full route Bug 1855811: Allow Tekton Event Listeners to render without a full route Jul 10, 2020
@openshift-ci-robot
Copy link
Contributor

@andrewballantyne: All pull requests linked via external trackers have merged: . Bugzilla bug 1855811 has been moved to the MODIFIED state.

In response to this:

Bug 1855811: Allow Tekton Event Listeners to render without a full route

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants