Bug 1843311: Kubevirt vm wizard create to confirm #5812
Conversation
openshift-ci-robot
added
bugzilla/severity-medium
|
@yaacov: This pull request references Bugzilla bug 1843311, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
| @@ -4,7 +4,7 @@ export const CREATE_VM = 'Create Virtual Machine'; | |||
| export const CREATE_VM_TEMPLATE = `${CREATE_VM} Template`; | |||
| export const IMPORT = `Import`; | |||
| export const IMPORT_VM = 'Import Virtual Machine'; | |||
| export const REVIEW_AND_CREATE = 'Review and create'; | |||
| export const REVIEW_AND_CONFIRM = 'Review and confirm'; | |||
| export const REVIEW_AND_IMPORT = 'Review and import'; | |||
There was a problem hiding this comment.
In that case, we can use the same label for create and import
yaacov
force-pushed
the
kubevirt-vm-wizard-create-to-confirm
branch
from
2070592
to
3d6369f
Compare
|
/test images |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: suomiy, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@yaacov: All pull requests linked via external trackers have merged: openshift/console#5812. Bugzilla bug 1843311 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
On VM wizard, click button "Review and create" jumps to "Review and confirm your settings" page and the create button "Create Virtual Machine" is on that page, so it's reasonable to lable "Review and create" to "Review and confirm".
Screeshots:
Before:
After:
