Add markdown support to OperatorHub and InstalledOperators pages #5827
Conversation
openshift-ci-robot
added
component/olm
|
Screens: |
| @@ -89,13 +89,19 @@ export class SyncMarkdownView extends React.Component< | |||
| <link rel="stylesheet" href="${link.href}">`, | |||
| '', | |||
| ); | |||
| const content = this.props.truncateContent | |||
| ? _.truncate(this.props.content, { | |||
| length: 100, | |||
There was a problem hiding this comment.
100 feels a little too short. Maybe 256?
There was a problem hiding this comment.
I wanted to leave it to approx. 3 lines, which is about 100+- chars
There was a problem hiding this comment.
I wanted to leave it to approx. 3 lines, which is about 100+- chars
I don't think it's enough content to describe some resources. We're really trying to catch the extreme cases where there are paragraphs of text.
jhadvig
force-pushed
the
markdown_support
branch
from
ffa2296
to
5651c9b
Compare
|
@spadgett comments addressed. PTAL |
|
/test e2e-gcp-console |
|
@spadgett I think we are good to go here :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adding support for markdown based on jira story specification. First I wanted to truncate the blocks using CSS but then Ive realised that its a bit tricky since we are creating multiple paragraph blocks so figured our that best would be to truncated text itself.
/assign @spadgett