New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add broker and trigger datamodel and visualization #5838
Add broker and trigger datamodel and visualization #5838
Conversation
3d98cfb
to
201cb87
Compare
73ae21b
to
205e492
Compare
205e492
to
0afc0ef
Compare
frontend/packages/knative-plugin/src/actions/add-pubsub-actions.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/topology/components/knativeComponentUtils.ts
Show resolved
Hide resolved
cfb473f
to
ffc1732
Compare
frontend/packages/knative-plugin/src/topology/knative-topology-utils.ts
Outdated
Show resolved
Hide resolved
80da05e
to
899f415
Compare
@karthikjeeyar Thanks Verified locally , seems to work as expected with broker / trigger with and without filter's
|
899f415
to
c49ceda
Compare
/lgtm /assign @christianvogt |
c49ceda
to
72398a1
Compare
@christianvogt @invincibleJai I have made the following changes
|
/retest |
@karthikjeeyar please create a new issue to address the trigger filter marker /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, invincibleJai, karthikjeeyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: https://issues.redhat.com/browse/ODC-4161
Analysis / Root cause:
Topology view doesn't support eventing brokers, triggers and its association with knative service
Solution:
Note: (Things are not covered part of this PR)
Screenshots
kebab actions:
Broker context menu:
Trigger sidebar:
GIF:
Unit Test:
cc: @serenamarie125 @beaumorley @openshift/team-devconsole-ux @christianvogt