New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FormHeader and update helm form title to be reactive #5851
Add FormHeader and update helm form title to be reactive #5851
Conversation
5b47ba2
to
77713b0
Compare
tried this out locally and it works fine |
/assign @christianvogt |
77713b0
to
b81e309
Compare
/retest |
1 similar comment
/retest |
frontend/packages/dev-console/src/components/helm/helm-utils.ts
Outdated
Show resolved
Hide resolved
c2a485e
to
80ee293
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohitkrai03 The text message under "Upgrade Helm Release' are as follows:
For the 'Form view'- Upgrade by selecting a new chart version or manually changing the form values.For more information on the chart, refer to this README.
For the 'YAML view '- Upgrade by selecting a new chart version or manually changing YAML.For more information on the chart, refer to this README.
80ee293
to
e47199e
Compare
e47199e
to
fe0cb4e
Compare
@parvathyvr Updated the sub title for upgrade form. |
fe0cb4e
to
140932d
Compare
@parvathyvr @beaumorley @serenamarie125 Updated the grid layout for the form based on our conversation from yesterday's Helm meeting so that the form can acquire more real estate than before. It follows the same breaking points as the OLM form now. Please take a look at the below gif. cc: @christianvogt |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, debsmita1, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Fixes: https://issues.redhat.com/browse/ODC-4229
Analysis / Root cause: Latest changes to helm install/upgrade form needed the subtitle for the form to change when user toggle between form view and yaml view. but the page title for the form was at page level and had no idea of the form context.
Solution Description:
FormHeader
component that abstracts the page title logic and implements the current design properly.Screen shots / Gifs for design review:
cc: @openshift/team-devconsole-ux @parvathyvr
Unit test coverage report:
Browser conformance: