Changing context in monitoring dashboard #5852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @karthikjeeyar @gajanan-more |
There was a problem hiding this comment.
Few suggestions to add more scenarios
- By clicking on the monitoring nav item from navigation, by default All Workloads should be selected
- By selecting a workload in the dropdown and refreshing the page should auto select the previously selected workload
- If a workload is selected and if user switches to a different project from project selector, then filter dropdown option should be set to
All workloads
sanketpathak
force-pushed
the
Changing_context_in_Monitoring_Dashboard_3898
branch
from
7ae96bb
to
d52fae7
Compare
gajanan-more
suggested changes
Jun 30, 2020
...-console/integration-tests/features/monitoring/Changing_context_in_Monitoring_Dashboard_3898
Outdated
Show resolved
Hide resolved
...-console/integration-tests/features/monitoring/Changing_context_in_Monitoring_Dashboard_3898
Show resolved
Hide resolved
...-console/integration-tests/features/monitoring/Changing_context_in_Monitoring_Dashboard_3898
Outdated
Show resolved
Hide resolved
...-console/integration-tests/features/monitoring/Changing_context_in_Monitoring_Dashboard_3898
Outdated
Show resolved
Hide resolved
...-console/integration-tests/features/monitoring/Changing_context_in_Monitoring_Dashboard_3898
Outdated
Show resolved
Hide resolved
...-console/integration-tests/features/monitoring/Changing_context_in_Monitoring_Dashboard_3898
Outdated
Show resolved
Hide resolved
...-console/integration-tests/features/monitoring/Changing_context_in_Monitoring_Dashboard_3898
Outdated
Show resolved
Hide resolved
...-console/integration-tests/features/monitoring/Changing_context_in_Monitoring_Dashboard_3898
Outdated
Show resolved
Hide resolved
...-console/integration-tests/features/monitoring/Changing_context_in_Monitoring_Dashboard_3898
Outdated
Show resolved
Hide resolved
...-console/integration-tests/features/monitoring/Changing_context_in_Monitoring_Dashboard_3898
Outdated
Show resolved
Hide resolved
sanketpathak
force-pushed
the
Changing_context_in_Monitoring_Dashboard_3898
branch
from
d52fae7
to
faf0795
Compare
gajanan-more
suggested changes
Jul 1, 2020
...-console/integration-tests/features/monitoring/Changing_context_in_Monitoring_Dashboard_3898
Outdated
Show resolved
Hide resolved
...-console/integration-tests/features/monitoring/Changing_context_in_Monitoring_Dashboard_3898
Outdated
Show resolved
Hide resolved
sanketpathak
force-pushed
the
Changing_context_in_Monitoring_Dashboard_3898
branch
from
faf0795
to
e3feb99
Compare
|
/lgtm |
makambalaji
suggested changes
Jul 1, 2020
...-console/integration-tests/features/monitoring/Changing_context_in_Monitoring_Dashboard_3898
Outdated
Show resolved
Hide resolved
...-console/integration-tests/features/monitoring/Changing_context_in_Monitoring_Dashboard_3898
Outdated
Show resolved
Hide resolved
...-console/integration-tests/features/monitoring/Changing_context_in_Monitoring_Dashboard_3898
Outdated
Show resolved
Hide resolved
...-console/integration-tests/features/monitoring/Changing_context_in_Monitoring_Dashboard_3898
Outdated
Show resolved
Hide resolved
...-console/integration-tests/features/monitoring/Changing_context_in_Monitoring_Dashboard_3898
Outdated
Show resolved
Hide resolved
...-console/integration-tests/features/monitoring/Changing_context_in_Monitoring_Dashboard_3898
Outdated
Show resolved
Hide resolved
...-console/integration-tests/features/monitoring/Changing_context_in_Monitoring_Dashboard_3898
Outdated
Show resolved
Hide resolved
| And user is at the developer perspective | ||
|
|
||
| @regression | ||
| Scenario: Checking filter dropdown for workloads on Monitoring Dashboard navigating from workloads |
There was a problem hiding this comment.
Suggested change
| Scenario: Checking filter dropdown for workloads on Monitoring Dashboard navigating from workloads | |
| Scenario: Auto selection of filter dropdown when navigating from topology |
There was a problem hiding this comment.
It's just not checking for auto-selection only hence the title
sanketpathak
force-pushed
the
Changing_context_in_Monitoring_Dashboard_3898
branch
from
e3feb99
to
479e96c
Compare
makambalaji
suggested changes
Jul 2, 2020
...-console/integration-tests/features/monitoring/Changing_context_in_Monitoring_Dashboard_3898
Outdated
Show resolved
Hide resolved
sanketpathak
force-pushed
the
Changing_context_in_Monitoring_Dashboard_3898
branch
from
479e96c
to
4867fbf
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gajanan-more, karthikjeeyar, makambalaji, sanketpathak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gherkin Script for epic ODC-3898
Story: https://issues.redhat.com/browse/ODC-4226