New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1852301: Add integration test for Utilization and Events #5855
Bug 1852301: Add integration test for Utilization and Events #5855
Conversation
@gouyang: This pull request references Bugzilla bug 1852301, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @gouyang. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@yaacov: This pull request references Bugzilla bug 1852301, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
/ok-to-test |
/retest |
@suomiy Could you please take a look? |
43af471
to
9983fcd
Compare
await browser.wait(waitForStringInElement(dashboardView.vmDetailsHostname, vm.name)); | ||
expect(dashboardView.vmDetailsName.getText()).toEqual(vm.name); | ||
expect(dashboardView.vmDetailsNamespace.getText()).toEqual(vm.namespace); | ||
expect(dashboardView.vmDetailsNode.getText()).not.toEqual(NOT_AVAILABLE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we test the hostname as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the hostname is tested above within await
, the installation of guest agent takes very long time, the monitor of guest agent is in Status card
, even the alert message disappeared, the hostname may not shows immediately, hence use await
for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah okay, I am sorry I missed that
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gouyang, suomiy, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@gouyang: All pull requests linked via external trackers have merged: openshift/console#5855. Bugzilla bug 1852301 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Implementation for https://polarion.engineering.redhat.com/polarion/#/project/CNV/workitem?id=CNV-3331 and https://polarion.engineering.redhat.com/polarion/#/project/CNV/workitem?id=CNV-3329.