Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VSCode file exclusions #5859

Merged

Conversation

glekner
Copy link
Contributor

@glekner glekner commented Jun 30, 2020

I have an issue in my macOS env where the VSCode IntelliSense would just stop working after some time, I believe it happens because of too much load overtime:

Webpack recompile => public/dist changes => VSCode re-index

this process happens 100s of times a day, and could cause the issue.
This change removes unnecessary files from the watcher and from the explorer.

Removed from watcher:

    "**/bower_components": true,
    "**/node_modules/**": true,
    "**/.cache-loader": true,
    "**/public/dist": true

Removed from files (They won't show on VSCode):

    "**/.cache-loader": true,
    "**/public/dist": true

@rawagner
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 30, 2020
@openshift-merge-robot openshift-merge-robot merged commit c3de608 into openshift:master Jun 30, 2020
@spadgett spadgett added this to the v4.6 milestone Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants