Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubevirt: don't show GA help info inside the wizard #5868

Merged

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Jul 1, 2020

Don't show GA help message and sub title when in wizard mode.

Screenshot:
Before:
screenshot-localhost_9000-2020 07 01-11_16_17

After:
screenshot-localhost_9000-2020 07 01-11_58_18

Overvew disks view after:
screenshot-localhost_9000-2020 07 01-11_57_22

@openshift-ci-robot openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label Jul 1, 2020
@yaacov
Copy link
Member Author

yaacov commented Jul 1, 2020

@pcbailey please review

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2020
@yaacov yaacov force-pushed the dont-show-ga-help-in-wizard branch from c55d8f4 to aa879b9 Compare July 1, 2020 08:51
@pcbailey
Copy link
Contributor

pcbailey commented Jul 1, 2020

/lgtm

@yaacov
Copy link
Member Author

yaacov commented Jul 1, 2020

@suomiy @pcbailey @glekner @irosenzw please review

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2020
@openshift-merge-robot openshift-merge-robot merged commit 01cc9d3 into openshift:master Jul 1, 2020
@spadgett spadgett added this to the v4.6 milestone Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants