Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address usability concerns with cluster upgrade visualization #5874

Merged
merged 1 commit into from Jul 1, 2020
Merged

Address usability concerns with cluster upgrade visualization #5874

merged 1 commit into from Jul 1, 2020

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Jul 1, 2020

  • Increase top/bottom padding on + More to increase size of click target
  • Darken available channel line to increase contrast
  • Bonus: DRY up CSS var usage

After:
Screen Shot 2020-07-01 at 11 26 51 AM
Hover state of + More
Screen Shot 2020-07-01 at 12 03 40 PM

@rhamilto
Copy link
Member Author

rhamilto commented Jul 1, 2020

/hold for ux approval

cc: @megan-hall

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2020
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 1, 2020
@rhamilto
Copy link
Member Author

rhamilto commented Jul 1, 2020

/hold cancel

/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2020
@megan-hall
Copy link

/hold for ux approval

cc: @megan-hall

LGTM!

sg00dwin
sg00dwin approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@sg00dwin sg00dwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5d355c8 into openshift:master Jul 1, 2020
@rhamilto rhamilto deleted the cluster-status-visualization-usability branch July 2, 2020 11:28
@spadgett spadgett added this to the v4.6 milestone Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sg00dwin sg00dwin sg00dwin approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

@kyoto kyoto Awaiting requested review from kyoto

Assignees

@sg00dwin sg00dwin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rhamilto @megan-hall @openshift-ci-robot @sg00dwin @spadgett @openshift-merge-robot