Add clone PVC feature #5884

cloudbehl · 2020-07-03T08:29:10Z

Signed-off-by: Ankush Behl cloudbehl@gmail.com

openshift-ci-robot · 2020-07-03T08:29:12Z

@cloudbehl: This pull request references Bugzilla bug 1853581, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1853581: Add clone PVC feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-07-03T08:32:11Z

@cloudbehl: This pull request references Bugzilla bug 1853581, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1853581: Add clone PVC feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cloudbehl · 2020-07-03T08:33:14Z

/bugzilla refresh

openshift-ci-robot · 2020-07-03T08:33:21Z

@cloudbehl: This pull request references Bugzilla bug 1853581, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-07-06T04:52:52Z

@cloudbehl: This pull request references Bugzilla bug 1853581, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1853581: Add clone PVC feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cloudbehl · 2020-07-06T04:53:38Z

@spadgett @zherman0 Please review.

openshift-ci-robot · 2020-07-06T13:27:22Z

@cloudbehl: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Add clone PVC feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cloudbehl · 2020-07-10T05:09:31Z

/assign @a2batic

frontend/public/components/modals/clone-pvc-modal.tsx

frontend/packages/console-app/src/components/modals/clone/_clone-pvc-modal.scss

frontend/packages/console-app/src/components/modals/clone/clone-pvc-modal.tsx

frontend/public/components/utils/kebab.tsx

gnehapk · 2020-07-14T08:48:09Z

frontend/packages/console-app/src/components/modals/clone/clone-pvc-modal.tsx


+  const pvcUsedCapacityQuery: string = `kubelet_volume_stats_used_bytes{persistentvolumeclaim='${pvcName}'}`;


This query should be moved to queries.ts file present inside console app.

I am in favor of having in the same file for visibility & doesn't need to be reused.

Since there is a file for queries, it make sense to move there. That's what has been followed with others.

Correct but if it's not reusable then it's fine to have it in here.

frontend/packages/console-app/src/components/modals/clone/clone-pvc-modal.tsx

a2batic · 2020-07-20T08:45:52Z

/lgtm
Working fine for me.

cloudbehl · 2020-07-20T16:59:00Z

@spadgett @rawagner can you review this PR?

rawagner · 2020-07-21T12:03:39Z

/lgtm

openshift-bot · 2020-07-21T13:40:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-21T15:11:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-21T16:02:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-21T16:15:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-21T16:28:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-21T16:54:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-21T17:33:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

rawagner · 2020-07-21T17:58:14Z

/hold

needs rebase

Signed-off-by: Ankush Behl <cloudbehl@gmail.com>

cloudbehl · 2020-07-23T04:13:09Z

/test analyze
/test images

rawagner · 2020-07-23T09:08:10Z

/hold cancel
/lgtm

openshift-ci-robot · 2020-07-23T09:08:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a2batic, cloudbehl, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-07-23T12:51:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-23T13:03:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-23T18:27:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jul 3, 2020

openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. component/core Related to console core functionality labels Jul 3, 2020

openshift-ci-robot requested review from dtaylor113 and zherman0 July 3, 2020 08:29

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 3, 2020

cloudbehl force-pushed the clone-feature branch from b61b0cc to fea123c Compare July 3, 2020 08:34

cloudbehl changed the title ~~Bug 1853581: Add clone PVC feature~~ Add clone PVC feature Jul 6, 2020

openshift-ci-robot removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 6, 2020

cloudbehl force-pushed the clone-feature branch from fea123c to fbe8174 Compare July 9, 2020 18:04

openshift-ci-robot added the component/ceph Related to ceph-storage-plugin label Jul 9, 2020

openshift-ci-robot assigned a2batic Jul 10, 2020

bipuladh suggested changes Jul 12, 2020

View reviewed changes

cloudbehl force-pushed the clone-feature branch 3 times, most recently from 4baca5c to 0fa9ada Compare July 14, 2020 06:58

bipuladh suggested changes Jul 14, 2020

View reviewed changes

gnehapk reviewed Jul 14, 2020

View reviewed changes

frontend/packages/console-app/src/components/modals/clone/clone-pvc-modal.tsx Outdated Show resolved Hide resolved

cloudbehl force-pushed the clone-feature branch from 0fa9ada to 4faf0bc Compare July 14, 2020 12:43

a2batic reviewed Jul 20, 2020

View reviewed changes

frontend/packages/console-app/src/components/modals/clone/clone-pvc-modal.tsx Outdated Show resolved Hide resolved

cloudbehl force-pushed the clone-feature branch from 7fe1be2 to 2616c65 Compare July 20, 2020 08:02

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2020

openshift-ci-robot assigned rawagner Jul 21, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2020

Add clone PVC feature

4a701bd

Signed-off-by: Ankush Behl <cloudbehl@gmail.com>

cloudbehl force-pushed the clone-feature branch from 2616c65 to 4a701bd Compare July 22, 2020 18:41

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 23, 2020

openshift-merge-robot merged commit 4767e97 into openshift:master Jul 23, 2020

spadgett added this to the v4.6 milestone Jul 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add clone PVC feature #5884

Add clone PVC feature #5884

cloudbehl commented Jul 3, 2020 •

edited

openshift-ci-robot commented Jul 3, 2020

openshift-ci-robot commented Jul 3, 2020

cloudbehl commented Jul 3, 2020

openshift-ci-robot commented Jul 3, 2020

openshift-ci-robot commented Jul 6, 2020

cloudbehl commented Jul 6, 2020

openshift-ci-robot commented Jul 6, 2020

cloudbehl commented Jul 10, 2020

gnehapk Jul 14, 2020

cloudbehl Jul 14, 2020

gnehapk Jul 15, 2020

cloudbehl Jul 15, 2020

a2batic commented Jul 20, 2020

cloudbehl commented Jul 20, 2020

rawagner commented Jul 21, 2020

openshift-bot commented Jul 21, 2020

openshift-bot commented Jul 21, 2020

openshift-bot commented Jul 21, 2020

openshift-bot commented Jul 21, 2020

openshift-bot commented Jul 21, 2020

openshift-bot commented Jul 21, 2020

openshift-bot commented Jul 21, 2020

rawagner commented Jul 21, 2020

cloudbehl commented Jul 23, 2020

rawagner commented Jul 23, 2020

openshift-ci-robot commented Jul 23, 2020

openshift-bot commented Jul 23, 2020

openshift-bot commented Jul 23, 2020

openshift-bot commented Jul 23, 2020


		const pvcUsedCapacityQuery: string = `kubelet_volume_stats_used_bytes{persistentvolumeclaim='${pvcName}'}`;

Add clone PVC feature #5884

Add clone PVC feature #5884

Conversation

cloudbehl commented Jul 3, 2020 • edited

openshift-ci-robot commented Jul 3, 2020

openshift-ci-robot commented Jul 3, 2020

cloudbehl commented Jul 3, 2020

openshift-ci-robot commented Jul 3, 2020

openshift-ci-robot commented Jul 6, 2020

cloudbehl commented Jul 6, 2020

openshift-ci-robot commented Jul 6, 2020

cloudbehl commented Jul 10, 2020

gnehapk Jul 14, 2020

Choose a reason for hiding this comment

cloudbehl Jul 14, 2020

Choose a reason for hiding this comment

gnehapk Jul 15, 2020

Choose a reason for hiding this comment

cloudbehl Jul 15, 2020

Choose a reason for hiding this comment

a2batic commented Jul 20, 2020

cloudbehl commented Jul 20, 2020

rawagner commented Jul 21, 2020

openshift-bot commented Jul 21, 2020

openshift-bot commented Jul 21, 2020

openshift-bot commented Jul 21, 2020

openshift-bot commented Jul 21, 2020

openshift-bot commented Jul 21, 2020

openshift-bot commented Jul 21, 2020

openshift-bot commented Jul 21, 2020

rawagner commented Jul 21, 2020

cloudbehl commented Jul 23, 2020

rawagner commented Jul 23, 2020

openshift-ci-robot commented Jul 23, 2020

openshift-bot commented Jul 23, 2020

openshift-bot commented Jul 23, 2020

openshift-bot commented Jul 23, 2020

cloudbehl commented Jul 3, 2020 •

edited