check for loaded or loadError in topology #5889
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://issues.redhat.com/browse/ODC-4250
Analysis / Root cause:
When a user does not have access to an optional resource, the k8s hook sets
loaded = false
andloadError = error
. Topology failed to considerloadError
as a signal that the resource fetching has completed.Solution Description:
Consider the resource to be have been fetched if
loaded || loadError
. After this initial check, non-optional resource load errors are checked in existing code.Screen shots / Gifs for design review:
Test setup:
Create a user with view and/or self-provisioner access (eg consoledeveloper test user)
Browser conformance:
cc @karthikjeeyar