Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for loaded or loadError in topology #5889

Merged

Conversation

christianvogt
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/ODC-4250

Analysis / Root cause:
When a user does not have access to an optional resource, the k8s hook sets loaded = false and loadError = error. Topology failed to consider loadError as a signal that the resource fetching has completed.

Solution Description:
Consider the resource to be have been fetched if loaded || loadError. After this initial check, non-optional resource load errors are checked in existing code.

Screen shots / Gifs for design review:

image

Test setup:

Create a user with view and/or self-provisioner access (eg consoledeveloper test user)

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

cc @karthikjeeyar

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Jul 3, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2020
@karthikjeeyar
Copy link
Contributor

verified locally, works fine
/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2020
@openshift-merge-robot openshift-merge-robot merged commit 6fe0932 into openshift:master Jul 6, 2020
@spadgett spadgett added this to the v4.6 milestone Jul 8, 2020
@christianvogt christianvogt deleted the topology-loadError branch August 20, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants