Add option to create snapshot for PVC #5893

a2batic · 2020-07-05T20:38:53Z

'Create Snapshot` action in kebab menu for PVC will allow
user to create in-time images of snapshot.

@bipuladh @cloudbehl
Signed-off-by: Kanika kmurarka@redhat.com

a2batic · 2020-07-05T20:39:50Z

/assign @rawagner @gnehapk @afreen23

cloudbehl · 2020-07-06T07:59:29Z

@a2batic

In PVC details we should have a name also for the PVC.
Creating a snapshot for {PVC} Claim? Also, we should point on the it will take time for snapshot to be in ready state.
Filtering snapshot classes by PVC provisioner is something we need to do.
Save should be Create to be consistent.

cloudbehl · 2020-07-10T06:12:18Z

Folder name inside the console app should be volume-snapshot & it should hold all the related components. I see some inconsistency in your & bipul's PR's related to naming.

rawagner · 2020-07-10T11:41:31Z

...tend/packages/console-app/src/components/create-volume-snapshot/_create-volume-snapshot.scss

+}
+
+.co-volume-snapshot__form {
+    margin: 20px 0;


we should use PF variables, also for co-volume-snapshot__details-body

rawagner · 2020-07-10T11:45:38Z

frontend/packages/console-app/src/components/create-volume-snapshot/create-volume-snapshot.tsx

+  namespace: string;
+  pvc: string;
+  status: string;
+  persistentVolumeClaim: K8sResourceKind;


would be nice to create a PersistentVolumeClaimKind

rawagner · 2020-07-10T11:50:36Z

frontend/public/components/utils/pvc-dropdown.tsx

+export const PVCDropdown: React.FC<PVCDropdownProps> = (props) => {
+  const kind = 'PersistentVolumeClaim';
+  const { namespace, selectedKey } = props;
+  const resources = [{ kind, namespace }];


Suggested change

const resources = [{ kind, namespace }];

const resources = [{ PersistentVolumeClaimModel.kind, namespace }];

rawagner · 2020-07-10T12:00:55Z

frontend/packages/console-app/src/components/create-volume-snapshot/create-volume-snapshot.tsx

+  );
+};
+
+// eslint-disable-next-line no-underscore-dangle


you should not disable the rule
the VolumeSnapshot_ can be written without dongle (and the current one is also missing types)

Suggested change

// eslint-disable-next-line no-underscore-dangle

export const VolumeSnapshot = connectToPlural<VolumeSnapshotProps>(

({ kindObj, kindsInFlight, match: { params } }) => {

if (!kindObj && kindsInFlight) {

return <LoadingBox />;

}

return (

<CreateSnapshotForm namespace={params.ns} resourceName={params.name} kindObj={kindObj} />

);

},

);

type VolumeSnapshotProps = WithPluralProps & {

match: match<{ name: string; ns: string }>;

};

gnehapk · 2020-07-11T12:53:29Z

frontend/packages/console-app/src/components/create-volume-snapshot/create-volume-snapshot.tsx

+  const { selectedKey, pvcProvisioner } = props;
+  const resources = [{ kind }];
+  const provisionerFilter = (snapshotClass: VolumeSnapshotClassKind) => {
+    return pvcProvisioner && pvcProvisioner.includes(snapshotClass?.driver);


nit: it can be returned directly. No need to use return.

gnehapk · 2020-07-11T13:03:07Z

frontend/packages/console-app/src/components/create-volume-snapshot/create-volume-snapshot.tsx

+  const [snapshotClassName, setSnapshotClassName] = React.useState<string>();
+  const [error, setError] = React.useState('');
+  const [inProgress, setInProgress] = React.useState(false);
+  const [pvcStatus, setPVCStatus] = React.useState<string>(null);


Shouldn't this be initialized with empty string instead of null here? I don't see that the value null is being used anywhere. Same for pvcProvisioner

gnehapk · 2020-07-11T13:08:16Z

frontend/packages/console-app/src/components/create-volume-snapshot/create-volume-snapshot.tsx

+    event.preventDefault();
+    setInProgress(true);
+    const snapshotTemplate: K8sResourceKind = {
+      apiVersion: `${VolumeSnapshotModel.apiGroup}/${VolumeSnapshotModel.apiVersion}`,


Suggested change

apiVersion: `${VolumeSnapshotModel.apiGroup}/${VolumeSnapshotModel.apiVersion}`,

apiVersion: `apiVersionForModel(VolumeSnapshotModel)

gnehapk · 2020-07-11T13:11:08Z

frontend/packages/console-app/src/components/create-volume-snapshot/create-volume-snapshot.tsx

+      }
+    };
+
+    setValue();


Suggested change

setValue();

updateValues();

gnehapk · 2020-07-11T13:15:31Z

frontend/packages/console-app/src/components/create-volume-snapshot/create-volume-snapshot.tsx

+      })
+      .catch((err) => {
+        setError(err.message || 'Could not create volume snapshot');
+        setInProgress(false);


You can create a finally block for setInProgress(false)

.finally(() => setInProgress(false);

gnehapk · 2020-07-11T13:16:26Z

frontend/packages/console-app/src/components/create-volume-snapshot/create-volume-snapshot.tsx

+      });
+  };
+
+  const title = 'Create VolumeSnapshot';


nit: move this variable definition after states declaration

gnehapk · 2020-07-11T13:18:29Z

frontend/packages/console-app/src/components/create-volume-snapshot/create-volume-snapshot.tsx

+            Creating snapshot for claim <strong>{resourceName}</strong>
+          </p>
+        )}
+        {pvcStatus && pvcStatus !== 'Bound' && (


I think you can directly use pvcStatus !== 'Bound' here once you define the pvsStatus with empty string

bipuladh · 2020-07-12T18:30:00Z

/hold
Let's push it after #5902 as pushing this without the list page doesn't make sense.

bipuladh · 2020-07-12T18:31:41Z

frontend/public/module/k8s/types.ts

+
+export type VolumeSnapshotClassKind = K8sResourceCommon & {
+  driver: string;
+  deletePolicy: string;


Suggested change

deletePolicy: string;

deletionPolicy: string;

bipuladh · 2020-07-12T18:35:51Z

...tend/packages/console-app/src/components/create-volume-snapshot/_create-volume-snapshot.scss

+    @media (max-width: 769px) {
+      display: none;
+    }
+
+    @media (max-width: 992px) {
+      display: none;
+    }
+
+    @media (min-width: 1200px) {
+      max-width: 50%;
+    }


I assume .pf-u-display-none and its breakpoint based variants should do the trick?

bipuladh · 2020-07-12T18:36:30Z

frontend/packages/console-app/src/components/create-volume-snapshot/create-volume-snapshot.tsx

+} from '@console/internal/models';
+import { PVCDropdown } from '@console/internal/components/utils/pvc-dropdown';
+
+import './_create-volume-snapshot.scss';


Move it to the end of the import declarations.

bipuladh · 2020-07-12T18:37:58Z

frontend/packages/console-app/src/components/create-volume-snapshot/create-volume-snapshot.tsx

+  persistentVolumeClaim,
+}) => {
+  const storageClass = persistentVolumeClaim?.spec?.storageClassName || '-';
+  const requestedCapacity = persistentVolumeClaim?.status?.capacity?.storage || '-';


nit: I think we get these values as G/T/Mi let's convert to G/T/MiB before showing.

We get the value as a string (eg. 1Gi ), so we need not convert.

I understand that but when we are displaying it to the user lets show it with B since that's the console standard.

bipuladh · 2020-07-12T18:38:27Z

frontend/packages/console-app/src/components/create-volume-snapshot/create-volume-snapshot.tsx

+  status,
+  persistentVolumeClaim,
+}) => {
+  const storageClass = persistentVolumeClaim?.spec?.storageClassName || '-';


Suggested change

const storageClass = persistentVolumeClaim?.spec?.storageClassName || '-';

const storageClass = persistentVolumeClaim?.spec?.storageClassName;

Isn't SC a required field for PVC creation?

bipuladh · 2020-07-12T19:31:37Z

frontend/packages/console-app/src/components/create-volume-snapshot/create-volume-snapshot.tsx

+              status={pvcStatus}
+              pvc={pvcName}


Suggested change

status={pvcStatus}

pvc={pvcName}

bipuladh · 2020-07-12T19:32:23Z

frontend/packages/console-app/src/components/create-volume-snapshot/create-volume-snapshot.tsx

+        setPVCStatus(pvc?.metadata?.deletionTimestamp ? 'Terminating' : pvc?.status?.phase);
+        setPVCProvisioner(sc?.provisioner);
+      } catch (err) {
+        setError(err);


I really don't think we should be showing the error if we cannot fetch the PVC list.

bipuladh · 2020-07-12T19:34:29Z

frontend/packages/console-app/src/components/create-volume-snapshot/create-volume-snapshot.tsx

+    const setValue = async () => {
+      try {
+        const pvc = await fetchK8s<K8sResourceKind>(PersistentVolumeClaimModel, pvcName, namespace);
+        const sc = await fetchK8s<StorageClassResourceKind>(
+          StorageClassModel,
+          pvc?.spec?.storageClassName,
+        );
+        setPVCObj(pvc);
+        setPVCStatus(pvc?.metadata?.deletionTimestamp ? 'Terminating' : pvc?.status?.phase);
+        setPVCProvisioner(sc?.provisioner);
+      } catch (err) {
+        setError(err);
+      }
+    };
+
+    setValue();


Suggested change

const setValue = async () => {

try {

const pvc = await fetchK8s<K8sResourceKind>(PersistentVolumeClaimModel, pvcName, namespace);

const sc = await fetchK8s<StorageClassResourceKind>(

StorageClassModel,

pvc?.spec?.storageClassName,

);

setPVCObj(pvc);

setPVCStatus(pvc?.metadata?.deletionTimestamp ? 'Terminating' : pvc?.status?.phase);

setPVCProvisioner(sc?.provisioner);

} catch (err) {

setError(err);

}

};

setValue();

( async () => {

try {

const pvc = await fetchK8s<K8sResourceKind>(PersistentVolumeClaimModel, pvcName, namespace);

const sc = await fetchK8s<StorageClassResourceKind>(

StorageClassModel,

pvc?.spec?.storageClassName,

);

setPVCObj(pvc);

setPVCStatus(pvc?.metadata?.deletionTimestamp ? 'Terminating' : pvc?.status?.phase);

setPVCProvisioner(sc?.provisioner);

} catch (err) {

setError(err);

}

})();

bipuladh · 2020-07-12T19:38:57Z

...tend/packages/console-app/src/components/create-volume-snapshot/_create-volume-snapshot.scss

+
+    @media (max-width: 992px) {
+      display: none;
+    }


shouldn't 992 cover 769 as well?

bipuladh · 2020-07-12T19:42:31Z

frontend/packages/ceph-storage-plugin/src/utils/kebab-actions.ts

-  }
-  if (resourceKind?.kind === VolumeSnapshotModel.kind) {
-    return [RestorePVC, DeleteSnapshot];
+    return [ClonePVC];


@cloudbehl I hope you have considered the creation of clone in your PR.

Yes & removal of stale objects is also taken care.

bipuladh · 2020-07-13T18:01:03Z

/hold cancel
#5902 has merged.

rawagner · 2020-07-16T10:14:27Z

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

+      .then((sc) => setSCObj(sc))
+      .catch((error) =>
+        // eslint-disable-next-line no-console
+        console.error(error),


we should have a better error handling, console logging is not very user friendly

rawagner · 2020-07-16T10:20:33Z

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

+  );
+};
+
+const CreateSnapshotForm = withHandlePromise((props: SnapshotResourceProps) => {


Suggested change

const CreateSnapshotForm = withHandlePromise((props: SnapshotResourceProps) => {

const CreateSnapshotForm = withHandlePromise<SnapshotResourceProps>((props) => {

rawagner · 2020-07-16T11:46:45Z

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

+    };
+  }, [namespace]);
+
+  const [data, loaded, loadError] = useK8sWatchResource(resourceWatch);


Suggested change

const [data, loaded, loadError] = useK8sWatchResource(resourceWatch);

const [data, loaded, loadError] = useK8sWatchResource<PersistentVolumeClaimKind[]>(resourceWatch);

rawagner · 2020-07-16T11:46:55Z

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

+
+  React.useEffect(() => {
+    if (!_.isEmpty(data)) {
+      const currentPVC = (data as PersistentVolumeClaimKind[]).find(


Suggested change

const currentPVC = (data as PersistentVolumeClaimKind[]).find(

const currentPVC = data.find(

rawagner · 2020-07-16T11:50:03Z

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

+        (pvc) => pvc.metadata.name === pvcName,
+      );
+      setPVCObj(currentPVC);
+      loadError || setError(loadError);


this should be outside of if. If error happens, data can be empty.

rawagner · 2020-07-16T11:52:02Z

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

+          /* eslint-disable jsx-a11y/label-has-associated-control */
+          <>
+            <label className="control-label co-required" html-for="claimName">
+              Persistent Volume claim


Suggested change

Persistent Volume claim

{PersistentVolumeClaimModel.label}

rawagner · 2020-07-16T11:52:31Z

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

+
+  const handlePVCName = (name: string) => {
+    if (!_.isEmpty(data)) {
+      const currentPVC = (data as PersistentVolumeClaimKind[]).find(


Suggested change

const currentPVC = (data as PersistentVolumeClaimKind[]).find(

const currentPVC = data.find(

rawagner · 2020-07-16T11:52:54Z

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

+      })
+      .catch((e) => {
+        // eslint-disable-next-line no-console
+        console.error(e);


needs better handling

rawagner · 2020-07-16T12:03:08Z

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

+  );
+});
+
+const VolumeSnapshotComponent = (props: VolumeSnapshotComponentProps) => {


Suggested change

const VolumeSnapshotComponent = (props: VolumeSnapshotComponentProps) => {

const VolumeSnapshotComponent: React.FC<VolumeSnapshotComponentProps> = (props) => {

rawagner · 2020-07-16T12:10:43Z

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

+
+  React.useEffect(() => {
+    k8sGet(StorageClassModel, pvcSC)
+      .then((sc) => setSCObj(sc))


Suggested change

.then((sc) => setSCObj(sc))

.then(setSCObj)

bipuladh · 2020-07-16T11:49:05Z

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

+  const [pvcName, setPVCName] = React.useState(resourceName);
+  const [pvcObj, setPVCObj] = React.useState(null);
+  const [snapshotName, setSnapshotName] = React.useState(`${pvcName || 'pvc'}-snapshot`);
+  const [snapshotClassName, setSnapshotClassName] = React.useState<string>();


Suggested change

const [snapshotClassName, setSnapshotClassName] = React.useState<string>();

const [snapshotClassName, setSnapshotClassName] = React.useState<string>('');

...nsole-app/src/components/volume-snapshot/create-volume-snapshot/_create-volume-snapshot.scss

bipuladh · 2020-07-16T13:11:44Z

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

+  const [pvcObj, setPVCObj] = React.useState(null);
+  const [snapshotName, setSnapshotName] = React.useState(`${pvcName || 'pvc'}-snapshot`);
+  const [snapshotClassName, setSnapshotClassName] = React.useState<string>();
+  const [error, setError] = React.useState(null);


Suggested change

const [error, setError] = React.useState(null);

const [error, setError] = React.useState('');

bipuladh · 2020-07-16T13:16:01Z

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

+  const resourceWatch = React.useMemo(() => {
+    return {
+      kind: PersistentVolumeClaimModel.kind,
+      namespace,
+      isList: true,
+    };
+  }, [namespace]);


Suggested change

const resourceWatch = React.useMemo(() => {

return {

kind: PersistentVolumeClaimModel.kind,

namespace,

isList: true,

};

}, [namespace]);

const resourceWatch = React.useMemo(() => {

return Object.assign({

kind: PersistentVolumeClaimModel.kind,

namespace,

isList: true,

}, pvcName ? { name: pvcName } : null);

}, [namespace, pvcName]);

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

...nsole-app/src/components/volume-snapshot/create-volume-snapshot/_create-volume-snapshot.scss

bipuladh · 2020-07-21T03:13:44Z

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

+  const { resourceName, namespace, kindObj, handlePromise, inProgress, errorMessage } = props;
+
+  const [pvcName, setPVCName] = React.useState(resourceName);
+  const [pvcObj, setPVCObj] = React.useState(null);


Suggested change

const [pvcObj, setPVCObj] = React.useState(null);

const [pvcObj, setPVCObj] = React.useState<PersistentVolumeClaimKind>(null);

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

frontend/public/components/utils/pvc-dropdown.tsx

bipuladh · 2020-07-21T03:21:36Z

frontend/packages/console-app/src/components/volume-snapshot/volume-snapshot.tsx

+  match: {
+    params: {
+      ns: string;
+      plural: string;
+    };
+  };
+};


Suggested change

match: {

params: {

ns: string;

plural: string;

};

};

};

match: match<{ns?: string, plural?:string}>;

frontend/packages/console-app/src/components/volume-snapshot/volume-snapshot.tsx

bipuladh · 2020-07-21T03:23:01Z

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

+      .catch((e) => {
+        throw e;
+      });


Why catch just to throw again?

a2batic · 2020-07-21T08:22:22Z

@bipuladh as per offline conversations, have resolved some comments, and addressed other comments. Please review.

bipuladh · 2020-07-21T08:25:33Z

/approve
/lgtm

rawagner · 2020-07-21T09:08:10Z

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

+  PersistentVolumeModel,
+} from '@console/internal/models';
+import { PVCDropdown } from '@console/internal/components/utils/pvc-dropdown';
+import { apiVersionForModel } from '@console/kubevirt-plugin/integration-tests/tests/utils/selectors';


dont import from kubevirt-plugin

rawagner · 2020-07-21T09:12:14Z

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

+};
+
+const PVCSummary: React.FC<PVCSummaryProps> = ({ persistentVolumeClaim }) => {
+  const accessModeLabels = Object.freeze({


can you reuse https://github.com/openshift/console/blob/master/frontend/public/components/storage/shared.ts#L21 ?

user to create in-time images of snapshot. Jira: https://issues.redhat.com/browse/RHSTOR-1154 Signed-off-by: Kanika <kmurarka@redhat.com>

rawagner · 2020-07-21T09:47:47Z

/lgtm

openshift-ci-robot · 2020-07-21T09:48:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a2batic, bipuladh, cloudbehl, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cloudbehl · 2020-07-16T12:01:13Z

frontend/public/module/k8s/types.ts

@@ -991,3 +991,19 @@ export type VolumeSnapshotClassKind = K8sResourceCommon & {
  deletionPolicy: string;
  driver: string;
 };
+
+export type PersistentVolumeClaimKind = K8sResourceCommon & {


nit: add source object to accommodate cloning

ack, as per offline converstaion, will be taking it up in follow-up PR.

cloudbehl · 2020-07-20T06:31:15Z

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

+
+const PVCSummary: React.FC<PVCSummaryProps> = ({ persistentVolumeClaim }) => {
+  const storageClass = persistentVolumeClaim?.spec?.storageClassName;
+  const requestedCapacity = persistentVolumeClaim?.spec?.resources?.requests?.storage;


nit: This is required in the PVC object so we don't need to check all entities.

Suggested change

const requestedCapacity = persistentVolumeClaim?.spec?.resources?.requests?.storage;

const requestedCapacity = persistentVolumeClaim?.spec.resources.requests.storage;

ack, as per offline converstaion, will be taking it up in follow-up PR.

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. component/ceph Related to ceph-storage-plugin labels Jul 5, 2020

openshift-ci-robot requested review from shyRozen and zherman0 July 5, 2020 20:39

openshift-ci-robot added the component/core Related to console core functionality label Jul 5, 2020

openshift-ci-robot assigned afreen23, gnehapk and rawagner Jul 5, 2020

a2batic marked this pull request as draft July 5, 2020 20:40

a2batic marked this pull request as ready for review July 5, 2020 20:41

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2020

a2batic force-pushed the snapshot-modal branch from d2606f7 to 26f8fef Compare July 7, 2020 20:42

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2020

a2batic changed the title ~~[WIP] Add option to create snapshot for PVC~~ Add option to create snapshot for PVC Jul 9, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2020

rawagner suggested changes Jul 10, 2020

View reviewed changes

gnehapk reviewed Jul 11, 2020

View reviewed changes

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2020

bipuladh suggested changes Jul 12, 2020

View reviewed changes

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2020

a2batic requested a review from bipuladh July 16, 2020 09:09

a2batic force-pushed the snapshot-modal branch from 6d022c6 to 69a757a Compare July 16, 2020 09:18

rawagner suggested changes Jul 16, 2020

View reviewed changes

bipuladh suggested changes Jul 16, 2020

View reviewed changes

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2020

a2batic force-pushed the snapshot-modal branch 2 times, most recently from 203b188 to 6f65827 Compare July 20, 2020 18:28

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2020

a2batic requested review from bipuladh and rawagner July 20, 2020 18:39

a2batic commented Jul 20, 2020

View reviewed changes

...nsole-app/src/components/volume-snapshot/create-volume-snapshot/_create-volume-snapshot.scss Show resolved Hide resolved

a2batic force-pushed the snapshot-modal branch from 6f65827 to d101aec Compare July 20, 2020 20:26

bipuladh suggested changes Jul 21, 2020

View reviewed changes

a2batic force-pushed the snapshot-modal branch from d101aec to 1d517f1 Compare July 21, 2020 08:20

openshift-ci-robot assigned bipuladh Jul 21, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2020

rawagner reviewed Jul 21, 2020

View reviewed changes

'Create Snapshot' action in kebab menu for PVC will allow

c258cf6

user to create in-time images of snapshot. Jira: https://issues.redhat.com/browse/RHSTOR-1154 Signed-off-by: Kanika <kmurarka@redhat.com>

a2batic force-pushed the snapshot-modal branch from 1d517f1 to c258cf6 Compare July 21, 2020 09:34

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2020

cloudbehl reviewed Jul 21, 2020

View reviewed changes

openshift-merge-robot merged commit 33ee022 into openshift:master Jul 21, 2020

spadgett added this to the v4.6 milestone Jul 21, 2020

	const resources = [{ kind, namespace }];
	const resources = [{ PersistentVolumeClaimModel.kind, namespace }];

-// eslint-disable-next-line no-underscore-dangle
+export const VolumeSnapshot = connectToPlural<VolumeSnapshotProps>(
+  ({ kindObj, kindsInFlight, match: { params } }) => {
+    if (!kindObj && kindsInFlight) {
+      return <LoadingBox />;
+    }
+    return (
+      <CreateSnapshotForm namespace={params.ns} resourceName={params.name} kindObj={kindObj} />
+    );
+  },
+);
+type VolumeSnapshotProps = WithPluralProps & {
+  match: match<{ name: string; ns: string }>;
+};

	apiVersion: `${VolumeSnapshotModel.apiGroup}/${VolumeSnapshotModel.apiVersion}`,
	apiVersion: `apiVersionForModel(VolumeSnapshotModel)

	const storageClass = persistentVolumeClaim?.spec?.storageClassName \|\| '-';
	const storageClass = persistentVolumeClaim?.spec?.storageClassName;

	const CreateSnapshotForm = withHandlePromise((props: SnapshotResourceProps) => {
	const CreateSnapshotForm = withHandlePromise<SnapshotResourceProps>((props) => {

	const [data, loaded, loadError] = useK8sWatchResource(resourceWatch);
	const [data, loaded, loadError] = useK8sWatchResource<PersistentVolumeClaimKind[]>(resourceWatch);

	const currentPVC = (data as PersistentVolumeClaimKind[]).find(
	const currentPVC = data.find(

	const VolumeSnapshotComponent = (props: VolumeSnapshotComponentProps) => {
	const VolumeSnapshotComponent: React.FC<VolumeSnapshotComponentProps> = (props) => {

	const [snapshotClassName, setSnapshotClassName] = React.useState<string>();
	const [snapshotClassName, setSnapshotClassName] = React.useState<string>('');

	const [error, setError] = React.useState(null);
	const [error, setError] = React.useState('');

	const [pvcObj, setPVCObj] = React.useState(null);
	const [pvcObj, setPVCObj] = React.useState<PersistentVolumeClaimKind>(null);

	const requestedCapacity = persistentVolumeClaim?.spec?.resources?.requests?.storage;
	const requestedCapacity = persistentVolumeClaim?.spec.resources.requests.storage;

Add option to create snapshot for PVC #5893

Add option to create snapshot for PVC #5893

Conversation

a2batic commented Jul 5, 2020 • edited

a2batic commented Jul 5, 2020

cloudbehl commented Jul 6, 2020

cloudbehl commented Jul 10, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gnehapk Jul 11, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bipuladh commented Jul 12, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bipuladh Jul 14, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bipuladh commented Jul 13, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

a2batic commented Jul 21, 2020

bipuladh commented Jul 21, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rawagner commented Jul 21, 2020

openshift-ci-robot commented Jul 21, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

a2batic commented Jul 5, 2020 •

edited

gnehapk Jul 11, 2020 •

edited

bipuladh Jul 14, 2020 •

edited