Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1854652: Adjustments for alignment and spacing on the following search elements #5900

Merged

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Jul 6, 2020

Screen Shot 2020-07-06 at 5 14 27 PM

Corrected version

Screen Shot 2020-07-06 at 4 57 14 PM

Screen Shot 2020-07-06 at 5 18 23 PM

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Jul 6, 2020
@sg00dwin sg00dwin requested a review from spadgett July 6, 2020 21:33
@sg00dwin sg00dwin force-pushed the search-related-fixes branch 2 times, most recently from f780375 to 7857735 Compare July 8, 2020 15:50
@sg00dwin
Copy link
Member Author

sg00dwin commented Jul 8, 2020

/retest

frontend/public/components/_search.scss Outdated Show resolved Hide resolved
@media (min-width: $screen-sm-min) {
.co-search-group__accordion-toggle {
--pf-c-accordion__toggle--PaddingLeft: 30px;
--pf-c-accordion__toggle--PaddingRight: 30px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--pf-c-accordion__toggle--PaddingRight: 30px;
--pf-c-accordion__toggle--PaddingRight: $grid-gutter-width;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that using --pf-c-accordion__toggle--PaddingRight: $grid-gutter-width; doesn't render, so I'm switching padding-left padding-right with the $grid-gutter-width

accordion toggle left and right padding
empty results help message
spacing between pf-c-toolbar and filters to match events filter
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit 3a39109 into openshift:master Jul 10, 2020
@sg00dwin sg00dwin deleted the search-related-fixes branch July 14, 2020 13:58
@spadgett spadgett added this to the v4.6 milestone Jul 14, 2020
@spadgett spadgett changed the title Adjustments for alignment and spacing on the following search elements Bug 1854652: Adjustments for alignment and spacing on the following search elements Jul 31, 2020
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: All pull requests linked via external trackers have merged: . Bugzilla bug 1854652 has been moved to the MODIFIED state.

In response to this:

Bug 1854652: Adjustments for alignment and spacing on the following search elements

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants