New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1854652: Adjustments for alignment and spacing on the following search elements #5900
Bug 1854652: Adjustments for alignment and spacing on the following search elements #5900
Conversation
f780375
to
7857735
Compare
/retest |
@media (min-width: $screen-sm-min) { | ||
.co-search-group__accordion-toggle { | ||
--pf-c-accordion__toggle--PaddingLeft: 30px; | ||
--pf-c-accordion__toggle--PaddingRight: 30px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--pf-c-accordion__toggle--PaddingRight: 30px; | |
--pf-c-accordion__toggle--PaddingRight: $grid-gutter-width; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that using --pf-c-accordion__toggle--PaddingRight: $grid-gutter-width;
doesn't render, so I'm switching padding-left
padding-right
with the $grid-gutter-width
accordion toggle left and right padding empty results help message spacing between pf-c-toolbar and filters to match events filter
7857735
to
72418ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, sg00dwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sg00dwin: All pull requests linked via external trackers have merged: . Bugzilla bug 1854652 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Corrected version