Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1854131: Machine's 'Provisioned as node' phase should use SuccessStatus component with GreenCheckCircleIcon icon #5901

Merged
merged 1 commit into from Jul 7, 2020
Merged

Bug 1854131: Machine's 'Provisioned as node' phase should use SuccessStatus component with GreenCheckCircleIcon icon #5901

merged 1 commit into from Jul 7, 2020

Conversation

jhadvig
Copy link
Member

@jhadvig jhadvig commented Jul 7, 2020

/assign @spadgett

@jhadvig
Bug 1854131: Machine's 'Provisioned as node' phase should use Success…
e274ffb 
…Status component with GreenCheckCircleIcon icon
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 7, 2020
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Bugzilla bug 1854131, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1854131: Machine's 'Provisioned as node' phase should use SuccessStatus component with GreenCheckCircleIcon icon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the component/shared Related to console-shared label Jul 7, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2020
@jhadvig
Copy link
Member Author

jhadvig commented Jul 7, 2020

/cherrypick release-4.5

@openshift-cherrypick-robot
Copy link

@jhadvig: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jhadvig
Copy link
Member Author

jhadvig commented Jul 7, 2020

/test e2e-gcp-console

@jomeier jomeier mentioned this pull request Jul 7, 2020
Closed
@spadgett
Copy link
Member

spadgett commented Jul 7, 2020

/cc @andybraren

spadgett
spadgett approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

I'm going to add a hold in case @andybraren wants to comment.
/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jul 7, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andybraren
Copy link
Contributor

andybraren commented Jul 7, 2020 •
edited

Nice, this feels more appropriate than the running icon we use today for this "end" state, /lgtm !

@jhadvig
Copy link
Member Author

jhadvig commented Jul 7, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2020
@openshift-merge-robot openshift-merge-robot merged commit a03578b into openshift:master Jul 7, 2020
@openshift-ci-robot
Copy link
Contributor

@jhadvig: All pull requests linked via external trackers have merged: openshift/console#5901. Bugzilla bug 1854131 has been moved to the MODIFIED state.

In response to this:

Bug 1854131: Machine's 'Provisioned as node' phase should use SuccessStatus component with GreenCheckCircleIcon icon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 7, 2020
Merged
@openshift-cherrypick-robot
Copy link

@jhadvig: new pull request created: #5910

In response to this:

/cherrypick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@zherman0 zherman0 Awaiting requested review from zherman0

@andybraren andybraren Awaiting requested review from andybraren

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jhadvig @openshift-ci-robot @openshift-cherrypick-robot @spadgett @andybraren @openshift-merge-robot