Add List and Details Page for Volume Snapshot Classes #5931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bipuladh
commented
Jul 9, 2020
•
bipuladh
commented
gnehapk
reviewed
Jul 10, 2020
frontend/packages/console-app/src/components/volume-snapshot/volume-snapshot-class-details.tsx
Outdated
Show resolved
Hide resolved
gnehapk
reviewed
Jul 10, 2020
| }; | ||
|
|
||
| const Row: React.FC<RowProps> = ({ obj, index, style, key }) => { | ||
| const { name } = obj?.metadata || {}; |
There was a problem hiding this comment.
obj -> volumeSnapshotClass something like this
There was a problem hiding this comment.
Is it really required?
There was a problem hiding this comment.
its more understandable IMO. Its up to you
|
@bipuladh Please rebase your PR and the screenshots for the respective pages. |
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.