Bug 1856155: Fixes deletion of node connected to a split node

[andrewballantyne]

Fixes:
https://issues.redhat.com/browse/ODC-3931

Analysis / Root cause:
When the original logic of Pipeline Builder was written, the code failed to properly handle a deletion of a node that had a runAfter (single or more) and was part of a runAfter that had multiple references. Essentially it just failed to carry over the removal node's runAfters to the the node that was connected to it... thus causing the break.

Solution Description:
Merge the runAfters together so it keeps all the data needed to hold the graph together.

Screen shots / Gifs for design review:

Error:

Fix:

Unit test coverage report:

Will be part of #4805

Test setup:

• OpenShift Pipeline Operator installed
• Create a pattern of "A - B" and then add a parallel task to "A", say "C", and then one more task to the left of "C".
• Delete "C"

Crude diagram:

    A - B
      /
D - C 

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[rohitkrai03]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [andrewballantyne,rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@andrewballantyne: All pull requests linked via external trackers have merged: . Bugzilla bug 1856155 has been moved to the MODIFIED state.

In response to this:

Bug 1856155: Fixes deletion of node connected to a split node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andrewballantyne]

/cherry-pick release-4.5

[openshift-cherrypick-robot]

@andrewballantyne: new pull request created: #5955

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.