Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add knative event source, channels and brokers to topology application dropdown #5949

Conversation

karthikjeeyar
Copy link
Contributor

@karthikjeeyar karthikjeeyar commented Jul 10, 2020

Fixes: https://issues.redhat.com/browse/ODC-4268

Analysis / Root cause:
Topology application dropdown doesn't support the knative event brokers, channels and event sources.

Solution:
Add all dynamic event sources, channels and brokers resource objects to the application dropdown's watcher list.

Screenshot:
knative-app-grouping

Browser Conformance:

  1. chrome
  2. firefox

@karthikjeeyar
Copy link
Contributor Author

/kind bug
/assign @christianvogt

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 10, 2020
@christianvogt
Copy link
Contributor

We're also missing CronJob, Job, Pod

Would be good to add those as well.

cc @jeff-phillips-18

@karthikjeeyar
Copy link
Contributor Author

Added cronJob, Job and Pod to the list.

image

@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit 335f024 into openshift:master Jul 10, 2020
@spadgett spadgett added this to the v4.6 milestone Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants