Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add create eventing channel via add flow #5950

Merged
merged 1 commit into from Jul 21, 2020
Merged

Add create eventing channel via add flow #5950

merged 1 commit into from Jul 21, 2020

Conversation

karthikjeeyar
Copy link
Contributor

@karthikjeeyar karthikjeeyar commented Jul 10, 2020 •
edited

Fixes:
https://issues.redhat.com/browse/ODC-4170,
https://issues.redhat.com/browse/ODC-4305 (yaml submission bug)

Analysis / Root cause:
Add creation of the channels via Add flow

Solution:

  1. Added card & Route for the channel
  2. Discovery and auto selection of default channel based on the namepaceDefaults in the defaults-ch-webhook configmap.
  3. Added support to additional fields for kafka form
  4. Error handling for yaml sections in create channle and also in event source yaml sections.

Screenshots:

Add Page Tile:
image

Auto selecting the default channel
image

Channel Type dropdown
image

Yaml section
image

adding channel
create-channel

Setup to run as basic user:
Create a ClusterRole with the following rules:

rules:
  - verbs:
      - get
      - watch
      - list
    apiGroups:
      - apiextensions.k8s.io
    resources:
      - customresourcedefinitions

Unit Test coverage

image

cc: @rachael-phillips @beaumorley @serenamarie125 @christianvogt @openshift/team-devconsole-ux

@openshift-ci-robot openshift-ci-robot added the component/knative Related to knative-plugin label Jul 10, 2020
@karthikjeeyar
Copy link
Contributor Author

/assign @invincibleJai

@karthikjeeyar
Copy link
Contributor Author

/kind feature

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 10, 2020
@rachael-phillips
Copy link

Hi @karthikjeeyar I think this is looking great so far. We are going to have a final review on the UX side for final recommendations and help text, but I understand if that needs to come in a later PR.

@serenamarie125
Copy link
Contributor

@karthikjeeyar @rachael-phillips quick question on this? Is it possible for us to use a heading which is the channel type immediately below the type dropdown? Right now it looks like it's only shown when thrown into YAML, but I think you could use is consistently between either mode. I'm not sure if the mocks included that or not?

@rachael-phillips
Copy link

Hey @serenamarie125 thanks for pointing that out because I think you're right that there is a consistency problem to be solved here. I looked into this across the console, and what I see we do in other instances of YAML across the console is no 2nd header. So while I thought originally this would help clarify the selection across the flow, now I am seeing we don't have that pattern as a precedent. That being said, would you be comfortable with removing the 2nd header from the YAML view in this design for consistency?

invincibleJai
invincibleJai reviewed Jul 14, 2020
View reviewed changes
frontend/packages/knative-plugin/src/models.ts Outdated Show resolved Hide resolved
frontend/packages/knative-plugin/src/components/add/channels/sections/YamlSection.tsx Outdated Show resolved Hide resolved
frontend/packages/knative-plugin/src/components/add/channels/ChannelForm.tsx Outdated Show resolved Hide resolved
frontend/packages/knative-plugin/src/utils/create-channel-utils.ts Outdated Show resolved Hide resolved
frontend/packages/knative-plugin/src/components/add/channels/ChannelForm.tsx Outdated Show resolved Hide resolved
frontend/packages/knative-plugin/src/utils/create-channel-utils.ts Outdated Show resolved Hide resolved
frontend/packages/knative-plugin/src/plugin.tsx Outdated Show resolved Hide resolved
frontend/packages/knative-plugin/src/utils/create-channel-utils.ts Outdated Show resolved Hide resolved
@karthikjeeyar karthikjeeyar force-pushed the feat-create-channel branch 2 times, most recently from 3095ed1 to 8aa9bf5 Compare July 14, 2020 15:12
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2020
@karthikjeeyar
Copy link
Contributor Author

/retest

@karthikjeeyar karthikjeeyar force-pushed the feat-create-channel branch 3 times, most recently from 551401e to 8b61935 Compare July 16, 2020 08:18
vikram-raj
vikram-raj reviewed Jul 16, 2020
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the UX, default channel types option should be at the top. Currently, it is in the second position.
Screenshot 2020-07-16 at 4 54 31 PM

@karthikjeeyar
Copy link
Contributor Author

@invincibleJai @vikram-raj Moved default channel always to the top

@rachael-phillips
Copy link

Hey @karthikjeeyar this is a super small thing, but it should say "Create a Knative Channel.." instead of "Create a Channel.."

@karthikjeeyar karthikjeeyar force-pushed the feat-create-channel branch 2 times, most recently from 71eced1 to 5f0c3a4 Compare July 17, 2020 03:49
vikram-raj
vikram-raj reviewed Jul 17, 2020
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the basic users, add channel page breaks.
Screenshot 2020-07-17 at 10 48 40 AM

@karthikjeeyar
Copy link
Contributor Author

@vikram-raj Fixed it.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2020
@openshift-ci-robot openshift-ci-robot added component/dashboard Related to dashboard component/shared Related to console-shared and removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 20, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2020
@karthikjeeyar
Copy link
Contributor Author

/retest

@karthikjeeyar
Copy link
Contributor Author

/test e2e-gcp-console

@invincibleJai
Copy link
Member

Verified the changes works as expected.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, karthikjeeyar, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1fe0743 into openshift:master Jul 21, 2020
@spadgett spadgett added this to the v4.6 milestone Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikram-raj vikram-raj vikram-raj left review comments

@invincibleJai invincibleJai invincibleJai left review comments

@rohitkrai03 rohitkrai03 Awaiting requested review from rohitkrai03

Assignees

@vikram-raj vikram-raj

@invincibleJai invincibleJai

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dashboard Related to dashboard component/knative Related to knative-plugin component/shared Related to console-shared kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@karthikjeeyar @rachael-phillips @serenamarie125 @abhi-kn @invincibleJai @openshift-bot @openshift-ci-robot @vikram-raj @spadgett @openshift-merge-robot