Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1856251: fix test env expect script timeout #5962

Merged
merged 1 commit into from Jul 14, 2020
Merged

Bug 1856251: fix test env expect script timeout #5962

merged 1 commit into from Jul 14, 2020

Conversation

rhrazdil
Copy link

For some reason, the executor VM in cnv-qe-jenkins cluster doesn't seem wait for the full duration of the set timeout 300.
Even when @irosenzw tried setting the timeout to 4000, the script failed sooner that that.
We decided for adding a minute sleep

@openshift-ci-robot
Copy link
Contributor

@rhrazdil: This pull request references Bugzilla bug 1856251, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1856251: fix test env expect script timeout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin labels Jul 13, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2020
@rhrazdil
Copy link
Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 13, 2020
@openshift-ci-robot
Copy link
Contributor

@rhrazdil: This pull request references Bugzilla bug 1856251, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

irosenzw
irosenzw reviewed Jul 13, 2020
View reviewed changes
...end/packages/kubevirt-plugin/integration-tests/tests/utils/scripts/expect-vm-env-readable.sh
@@ -21,7 +21,7 @@ spawn virtctl console $vm_name -n $vm_namespace --timeout 7

send -h "\n"

sleep 3
sleep 60

send -h \004
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment here saying we are sending ctrl+D to logout any logged-in users .

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops, forgot to add that, fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@irosenzw
Copy link
Contributor

/retest

@irosenzw
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irosenzw, rhrazdil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e417cd0 into openshift:master Jul 14, 2020
@openshift-ci-robot
Copy link
Contributor

@rhrazdil: All pull requests linked via external trackers have merged: openshift/console#5962. Bugzilla bug 1856251 has been moved to the MODIFIED state.

In response to this:

Bug 1856251: fix test env expect script timeout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irosenzw irosenzw irosenzw left review comments

@mareklibra mareklibra Awaiting requested review from mareklibra

@atiratree atiratree Awaiting requested review from atiratree

Assignees

@irosenzw irosenzw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rhrazdil @openshift-ci-robot @irosenzw @spadgett @openshift-merge-robot