Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 'tab key opens drawer fix' in console since css added upstream for PFv4 #5967

Conversation

dtaylor113
Copy link
Contributor

Reversion of #5577

Tabbing thru masthead icons does not open notification drawer.

JIRA: https://issues.redhat.com/browse/CONSOLE-2289

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Jul 13, 2020
Copy link
Member

@jcaianirh jcaianirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dtaylor113

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, jcaianirh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 13, 2020
@openshift-merge-robot openshift-merge-robot merged commit f05157b into openshift:master Jul 14, 2020
@spadgett spadgett added this to the v4.6 milestone Jul 14, 2020
@dtaylor113 dtaylor113 deleted the tab-notification-drawer-revert-cust-changes branch November 25, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants