Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1856477: Fix inline radio group after PF4 upgrade #5970

Merged

Conversation

rohitkrai03
Copy link
Contributor

Fixes: https://issues.redhat.com/browse/ODC-4310

Analysis / Root cause: After the PF4 upgrade, inline radio group is broken due to changes in PF classes.

Solution Description: Update the styles and use isInline prop for FormGroup component.

Screen shots / Gifs for design review:

Before -

Screenshot from 2020-07-13 23-33-27

After -

Screenshot from 2020-07-13 23-25-41

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the component/shared Related to console-shared label Jul 13, 2020
@rohitkrai03
Copy link
Contributor Author

/retest

2 similar comments
@rohitkrai03
Copy link
Contributor Author

/retest

@rohitkrai03
Copy link
Contributor Author

/retest

@rohitkrai03
Copy link
Contributor Author

/assign @christianvogt

@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2020
@openshift-merge-robot openshift-merge-robot merged commit f34c8e1 into openshift:master Jul 14, 2020
@spadgett spadgett added this to the v4.6 milestone Jul 16, 2020
@andrewballantyne
Copy link
Contributor

/retitle Bug 1856477: Fix inline radio group after PF4 upgrade

@openshift-ci-robot openshift-ci-robot changed the title Fix inline radio group after PF4 upgrade Bug 1856477: Fix inline radio group after PF4 upgrade Sep 2, 2020
@openshift-ci-robot
Copy link
Contributor

@rohitkrai03: Bugzilla bug 1856477 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Bug 1856477: Fix inline radio group after PF4 upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rohitkrai03 rohitkrai03 deleted the fix-inline-radio branch July 24, 2021 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants