New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1856477: Fix inline radio group after PF4 upgrade #5970
Bug 1856477: Fix inline radio group after PF4 upgrade #5970
Conversation
/retest |
2 similar comments
/retest |
/retest |
/assign @christianvogt |
8bc4a34
to
b85c7e7
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle Bug 1856477: Fix inline radio group after PF4 upgrade |
@rohitkrai03: Bugzilla bug 1856477 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes: https://issues.redhat.com/browse/ODC-4310
Analysis / Root cause: After the PF4 upgrade, inline radio group is broken due to changes in PF classes.
Solution Description: Update the styles and use
isInline
prop forFormGroup
component.Screen shots / Gifs for design review:
Before -
After -
Browser conformance: