Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jobs and CronJobs to list views #5973

Merged
merged 1 commit into from Jul 15, 2020

Conversation

jeff-phillips-18
Copy link
Member

Fixes:
https://issues.redhat.com/browse/ODC-4049
https://issues.redhat.com/browse/ODC-4050

Description:
As a Developer, I want to be able to see any workload type in the list views so I can better get a view of all of the computing resources being used. This adds Jobs, CronJobs, Pods.

Screen shots / Gifs for design review:

Project Workloads Tab:

image

image

Topology List View:

image

image

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

cc @openshift/team-devconsole-ux @serenamarie125 @beaumorley @bgliwa01

/kind feature

@openshift-ci-robot openshift-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. component/core Related to console core functionality labels Jul 13, 2020
@openshift-ci-robot openshift-ci-robot added the component/shared Related to console-shared label Jul 13, 2020
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I think we might have a bug in #5818

Sitting on Topology:
Screen Shot 2020-07-14 at 10 16 27 AM

Navigating away and returning:
Screen Shot 2020-07-14 at 10 17 21 AM

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2020
@andrewballantyne
Copy link
Contributor

/assign @christianvogt

@christianvogt
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2020
@openshift-merge-robot openshift-merge-robot merged commit 51fcf14 into openshift:master Jul 15, 2020
@serenamarie125
Copy link
Contributor

If this PR covers the Resource tab in Side panel, please include mocks :) Thanks @jeff-phillips-18

@jeff-phillips-18
Copy link
Member Author

@serenamarie125 Those were done already as part of #5818

@spadgett spadgett added this to the v4.6 milestone Jul 16, 2020
@jeff-phillips-18 jeff-phillips-18 deleted the list-view branch December 2, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/shared Related to console-shared kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants