Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1856530: Apply break-word mixin so that long strings don't cause horiztonal scroll within notifications bar. #5974

Merged
merged 1 commit into from Jul 13, 2020
Merged

Bug 1856530: Apply break-word mixin so that long strings don't cause horiztonal scroll within notifications bar. #5974

merged 1 commit into from Jul 13, 2020

Conversation

sg00dwin
Copy link
Member

…
After
Screen Shot 2020-07-13 at 3 50 59 PM

horz-scroll

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Jul 13, 2020
@spadgett
Copy link
Member

Unrelated to this change, but we should add Linkify to the alert messages. There are a lot with URLs.

spadgett
spadgett approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 13, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, sg00dwin, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcaianirh jcaianirh mentioned this pull request Jul 13, 2020
Closed
@jcaianirh
Copy link
Member

@sg00dwin thanks, opened this upstream: patternfly/patternfly#3285

@openshift-merge-robot openshift-merge-robot merged commit 820c7ac into openshift:master Jul 13, 2020
@spadgett spadgett changed the title Apply break-word mixin so that long strings don't cause horiztonal scroll within notifications bar. Bug 1856530: Apply break-word mixin so that long strings don't cause horiztonal scroll within notifications bar. Jul 14, 2020
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: All pull requests linked via external trackers have merged: . Bugzilla bug 1856530 has been moved to the MODIFIED state.

In response to this:

Bug 1856530: Apply break-word mixin so that long strings don't cause horiztonal scroll within notifications bar.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sg00dwin sg00dwin deleted the notifications-string-break branch July 14, 2020 13:57
@spadgett spadgett added this to the v4.6 milestone Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jcaianirh jcaianirh jcaianirh approved these changes

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@spadgett spadgett

@jcaianirh jcaianirh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sg00dwin @spadgett @openshift-ci-robot @jcaianirh @openshift-merge-robot