Bug 1854655: Bump to latest @patternfly/patternfly release (4.23.1)

[dtaylor113]

• Updated @patternfly/react-core to 4.31.1, and @patternfly/react-topology to 4.4.25
• Removed tippyProps in Tooltips
• Updated remaining @patternfly packages to latest versions
• Smoke test revealed no visual or behavioral regressions

[dtaylor113]

Seeing failures for unit tests which reference /console/frontend/node_modules/@popperjs:

FAIL __tests__/components/routes/create-route.spec.tsx
  ● Test suite failed to run
    /go/src/github.com/openshift/console/frontend/node_modules/@popperjs/core/lib/utils/getOppositePlacement.js:7
    export default function getOppositePlacement(placement) {
    ^^^^^^
    
    SyntaxError: Unexpected token export
      
      at new Script (vm.js:83:7)
      at Object.<anonymous> (node_modules/@patternfly/react-core/dist/js/helpers/Popper/Popper.js:8:56)

UPDATE: fixed, had to add @popperjs to jest transformIgnorePatterns

[spadgett]

Can you improve the types here?

nit: I'd spell it out to make it more clear: hideFunction (I'm assuming fnc means function)

[dtaylor113]

Fixed, changed to hideFunction. Can you pls elaborate on how to improve types? Using what PF-React has for Popover

[christianvogt]

Looking at the code it seems PF didn't update their types.

shouldClose?: (hideFnc: () => void) => void;

[dtaylor113]

PatternFly team working on a PR ( patternfly/patternfly-react#4543) which will restore tippyProps to avoid breaking changes. They are hoping to get the PR merged and part of this release.

[dtaylor113]

/hold

[christianvogt]

@dtaylor113 do we really need to wait for that PR? It doesn't affect us.

[jschuler]

I'm restoring tippyProps in that PR but it is really just a bandaid so that the build won't fail if react-core dependency is updated to latest. It has been deprecated. It'll be better to remove it as well as imported types from tippy.js. Please let me know if you have any other concerns/issues :)

[dtaylor113]

@dtaylor113 do we really need to wait for that PR? It doesn't affect us.

@christianvogt, I guess not as this PR makes the required changes to work with the latest Popover.

/hold cancel

[dtaylor113]

/retest

[christianvogt]

Ran PR and roamed the app. Tested topology tooltips.
/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, dtaylor113

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[spadgett]

This indirectly fixes https://bugzilla.redhat.com/show_bug.cgi?id=1854655

[openshift-ci-robot]

@dtaylor113: All pull requests linked via external trackers have merged: . Bugzilla bug 1854655 has been moved to the MODIFIED state.

In response to this:

Bug 1854655: Bump to latest @patternfly/patternfly release (4.23.1)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.