Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1857310: Give current line number more contrast in YAML editor #6001

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Bug 1857310: Give current line number more contrast in YAML editor #6001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 3 additions & 7 deletions frontend/packages/console-shared/src/components/editor/yaml-editor-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@ import {
import { getLanguageService, TextDocument } from 'yaml-language-server';
import { openAPItoJSONSchema } from '@console/internal/module/k8s/openapi-to-json-schema';
import { getStoredSwagger } from '@console/internal/module/k8s/swagger';
import {
global_BackgroundColor_100 as lineNumberActiveForeground,
spadgett marked this conversation as resolved.
Show resolved Hide resolved
global_BackgroundColor_200 as lineNumberForeground,
global_BackgroundColor_dark_100 as editorBackground,
} from '@patternfly/react-tokens';
import { global_BackgroundColor_dark_100 as editorBackground } from '@patternfly/react-tokens';

window.monaco.editor.defineTheme('console', {
base: 'vs-dark',
Expand All @@ -25,8 +21,8 @@ window.monaco.editor.defineTheme('console', {
colors: {
'editor.background': editorBackground.value,
'editorGutter.background': '#292e34', // no pf token defined
'editorLineNumber.activeForeground': lineNumberActiveForeground.value,
'editorLineNumber.foreground': lineNumberForeground.value,
'editorLineNumber.activeForeground': '#fff',
'editorLineNumber.foreground': '#f0f0f0',
},
});

Expand Down