Bug 1857809: Resource Quota title is duplicated #6015
Conversation
openshift-ci-robot
added
bugzilla/severity-low
|
@jhadvig: This pull request references Bugzilla bug 1857809, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
component/core
openshift-ci-robot
added
the
approved
|
This change results in the standalone Resource Quotas page losing its title. |
| @@ -428,6 +428,7 @@ export const ResourceQuotasPage = connectToFlags(FLAGS.OPENSHIFT)(({ namespace, | |||
| title="Resource Quotas" | |||
| rowFilters={rowFilters} | |||
| mock={mock} | |||
| showTitle={false} | |||
There was a problem hiding this comment.
| showTitle={false} | |
| showTitle={showTitle} |
Then change 387 as follows:
export const ResourceQuotasPage = connectToFlags(FLAGS.OPENSHIFT)(
({ namespace, flags, mock, showTitle }) => {
|
@rhamilto comment addressed. Thanks! |
|
/test e2e-gcp-console |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jhadvig: All pull requests linked via external trackers have merged: openshift/console#6015. Bugzilla bug 1857809 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @rhamilto