New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1856511: Correct alignment of help icons #6029
Bug 1856511: Correct alignment of help icons #6029
Conversation
@pcbailey: This pull request references Bugzilla bug 1856511, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
frontend/packages/console-shared/src/components/status/PopoverStatus.tsx
Outdated
Show resolved
Hide resolved
15000a6
to
b9a9106
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few questions around trying to align this a bit more visually to what PF has
frontend/packages/kubevirt-plugin/src/components/form/form-row.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/kubevirt-plugin/src/components/form/form-row.tsx
Outdated
Show resolved
Hide resolved
b9a9106
to
02d9cc0
Compare
<HelpIcon | ||
noVerticalAlign | ||
className={classnames({ | ||
'kubevirt-form-row__help-icon--hidden': !isActive, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove this class? I'm not sure what it's purpose is but it's adding a color override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the class and the logic that was used to apply it. I'm not sure why it was added originally, but I didn't see it being used anywhere else, so it doesn't appear to be any type of convention used for consistency.
02d9cc0
to
33b6cee
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pcbailey, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pcbailey: All pull requests linked via external trackers have merged: openshift/console#6029. Bugzilla bug 1856511 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR corrects help icon styles to comply with PF4 styles and accessibility guidelines.
Before:
After: