New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kind and apiVersion to resources returned from k8sList #6032
Add kind and apiVersion to resources returned from k8sList #6032
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it local and work as expected 👍
/lgtm
/cc @spadgett |
@spadgett Would you know why it doesn't return the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, jeff-phillips-18, jerolimov, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I don't know the history except that it's been this way since k8s 1.0. The 3.x console did what @jeff-phillips-18 is doing here and injected the api version and kind in our data service. |
Fixes
https://issues.redhat.com/browse/ODC-4351
Description
This PR adds
kind
andapiVersion
fields to the items returned fromk8sList
. Without those fields, the overview page needed to add them to the resources causing comparisons with newly retrieved items to fail though no data had changed.It makes sense that these items contain these fields and upon retrieval seems to be the best single place to set them.
/kind bug