Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kind and apiVersion to resources returned from k8sList #6032

Merged

Conversation

jeff-phillips-18
Copy link
Member

Fixes
https://issues.redhat.com/browse/ODC-4351

Description
This PR adds kind and apiVersion fields to the items returned from k8sList. Without those fields, the overview page needed to add them to the resources causing comparisons with newly retrieved items to fail though no data had changed.
It makes sense that these items contain these fields and upon retrieval seems to be the best single place to set them.

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 20, 2020
@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console component/shared Related to console-shared labels Jul 20, 2020
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2020
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it local and work as expected 👍

/lgtm

@jeff-phillips-18
Copy link
Member Author

/cc @spadgett

@andrewballantyne
Copy link
Contributor

@spadgett Would you know why it doesn't return the apiVersion and kind for each of the items? I assume this is for saving the bytes of data transfer, but it's near insignificant...

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, jeff-phillips-18, jerolimov, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2020
@spadgett
Copy link
Member

@spadgett Would you know why it doesn't return the apiVersion and kind for each of the items? I assume this is for saving the bytes of data transfer, but it's near insignificant...

I don't know the history except that it's been this way since k8s 1.0. The 3.x console did what @jeff-phillips-18 is doing here and injected the api version and kind in our data service.

@openshift-merge-robot openshift-merge-robot merged commit 7726c31 into openshift:master Jul 21, 2020
@spadgett spadgett added this to the v4.6 milestone Jul 28, 2020
@jeff-phillips-18 jeff-phillips-18 deleted the resource-fix branch December 2, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/shared Related to console-shared kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants