New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1871996: Made create role bindings links consistent #6035
Bug 1871996: Made create role bindings links consistent #6035
Conversation
@rebeccaalpert: This pull request references Bugzilla bug 1856350, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rebeccaalpert: This pull request references Bugzilla bug 1871996, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rebeccaalpert: This pull request references Bugzilla bug 1871996, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The "Create Binding" button under the Role Bindings tab on the Role details page linked to a namespaced or cluster bindings URL. Meanwhile, other pages only use the cluster URL. I made the URLs consistent. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1871996
226db0f
to
dca1877
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebeccaalpert, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rebeccaalpert: All pull requests linked via external trackers have merged: Bugzilla bug 1871996 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Note this reverses part of changes in openshift#6035 since that change caused bug 1927882.
Note this reverses part of changes in openshift#6035 since that change caused bug 1927882.
Note this reverses part of changes in openshift#6035 since that change caused bug 1927882.
Note this reverses part of changes in openshift#6035 since that change caused bug 1927882.
Note this reverses part of changes in openshift#6035 since that change caused bug 1927882.
Note this reverses part of changes in openshift#6035 since that change caused bug 1927882.
The "Create Binding" button under the Role Bindings tab on the Role details page linked to a namespaced or cluster bindings URL. Meanwhile, other pages only use the cluster URL. I made the URLs consistent.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1871996.