Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1871996: Made create role bindings links consistent #6035

Merged

Conversation

rebeccaalpert
Copy link
Contributor

@rebeccaalpert rebeccaalpert commented Jul 20, 2020

The "Create Binding" button under the Role Bindings tab on the Role details page linked to a namespaced or cluster bindings URL. Meanwhile, other pages only use the cluster URL. I made the URLs consistent.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1871996.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Jul 20, 2020
@openshift-ci-robot
Copy link
Contributor

@rebeccaalpert: This pull request references Bugzilla bug 1856350, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1856350: Made create role bindings links consistent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality labels Jul 20, 2020
@rebeccaalpert rebeccaalpert changed the title Bug 1856350: Made create role bindings links consistent Bug 1871996: Made create role bindings links consistent Aug 24, 2020
@openshift-ci-robot
Copy link
Contributor

@rebeccaalpert: This pull request references Bugzilla bug 1871996, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1871996: Made create role bindings links consistent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@rebeccaalpert: This pull request references Bugzilla bug 1871996, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1871996: Made create role bindings links consistent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

The "Create Binding" button under the Role Bindings tab on the Role details page linked to a namespaced or cluster bindings URL. Meanwhile, other pages only use the cluster URL. I made the URLs consistent.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1871996
@rebeccaalpert
Copy link
Contributor Author

/retest

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebeccaalpert, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2020
@openshift-merge-robot openshift-merge-robot merged commit 0d3e042 into openshift:master Aug 27, 2020
@openshift-ci-robot
Copy link
Contributor

@rebeccaalpert: All pull requests linked via external trackers have merged:

Bugzilla bug 1871996 has been moved to the MODIFIED state.

In response to this:

Bug 1871996: Made create role bindings links consistent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Sep 1, 2020
rhamilto added a commit to rhamilto/console that referenced this pull request Feb 15, 2021
Note this reverses part of changes in openshift#6035 since that change caused bug 1927882.
rhamilto added a commit to rhamilto/console that referenced this pull request Feb 15, 2021
Note this reverses part of changes in openshift#6035 since that change caused bug 1927882.
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/console that referenced this pull request Feb 16, 2021
Note this reverses part of changes in openshift#6035 since that change caused bug 1927882.
gouyang pushed a commit to gouyang/console that referenced this pull request Mar 4, 2021
Note this reverses part of changes in openshift#6035 since that change caused bug 1927882.
GowthamShanmugam pushed a commit to GowthamShanmugam/console that referenced this pull request Apr 26, 2021
Note this reverses part of changes in openshift#6035 since that change caused bug 1927882.
GowthamShanmugam pushed a commit to GowthamShanmugam/console that referenced this pull request Apr 26, 2021
Note this reverses part of changes in openshift#6035 since that change caused bug 1927882.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants