Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gherkin Scripts Workload Groupings and Resources Drop Down Menu Scenarios - [ODC-2922] #6047

Merged
merged 1 commit into from Jul 23, 2020
Merged

Gherkin Scripts Workload Groupings and Resources Drop Down Menu Scenarios - [ODC-2922] #6047

merged 1 commit into from Jul 23, 2020

Conversation

gajanan-more
Copy link
Contributor

@gajanan-more gajanan-more commented Jul 21, 2020 •
edited

Fixes: https://issues.redhat.com/browse/ODC-4073

Problem: Gherkin Scripts Design for Workload Groupings and Resources Drop Down Menu epic ODC-2922

Solution: These are the gherkin scripts designed covering all the scenarios related to Workload Groupings and Resources Drop Down Menu epic ODC-2922

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Jul 21, 2020
@gajanan-more
Copy link
Contributor Author

/assign @jeff-phillips-18

@gajanan-more
Copy link
Contributor Author

/assign @makambalaji @sanketpathak

makambalaji
makambalaji reviewed Jul 21, 2020
View reviewed changes
Copy link
Contributor

@makambalaji makambalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add @Manual tag only if automation is not possible for that scenarios

...ackages/dev-console/integration-tests/features/topology/resources-Groupings-ODC-2922.feature Outdated Show resolved Hide resolved
...ackages/dev-console/integration-tests/features/topology/resources-Groupings-ODC-2922.feature Outdated Show resolved Hide resolved
@jeff-phillips-18
Copy link
Member

The resource filter design is still in flux. Last I heard was that they will behave much like the catalog pages where if nothing is selected there are no filters. So, the default would be nothing selected. To show only DCs one would select the DC checkbox. To hide only DCs, the user would need to select everything except the DCs.

@gajanan-more gajanan-more changed the title Gherkin Scripts Helm Release Scenarios - [ODC-2922] Gherkin Scripts Workload Groupings and Resources Drop Down Menu Scenarios - [ODC-2922] Jul 21, 2020
@gajanan-more
Copy link
Contributor Author

Please add @Manual tag only if automation is not possible for that scenarios

Yes @makambalaji I thought about it and then only added the tags. These are the things we cannot determine in the automation. These things must to checked manually. There can be multiple cases of it and it's impossible to automate it.

@gajanan-more
Copy link
Contributor Author

The resource filter design is still in flux. Last I heard was that they will behave much like the catalog pages where if nothing is selected there are no filters. So, the default would be nothing selected. To show only DCs one would select the DC checkbox. To hide only DCs, the user would need to select everything except the DCs.

I will update the scenarios accordingly @jeff-phillips-18

@sanketpathak
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@makambalaji
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gajanan-more, makambalaji, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020
@sanketpathak sanketpathak mentioned this pull request Jul 22, 2020
Merged
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6ff7d53 into openshift:master Jul 23, 2020
@spadgett spadgett added this to the v4.6 milestone Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketpathak sanketpathak sanketpathak left review comments

@jeff-phillips-18 jeff-phillips-18 jeff-phillips-18 left review comments

@makambalaji makambalaji makambalaji left review comments

@kyoto kyoto Awaiting requested review from kyoto

Assignees

@sanketpathak sanketpathak

@jeff-phillips-18 jeff-phillips-18

@makambalaji makambalaji

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@gajanan-more @jeff-phillips-18 @sanketpathak @makambalaji @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot