Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1854198: Improve handling of descriptions in DynamicForm field components #6054

Merged
merged 1 commit into from Jul 27, 2020
Merged

Bug 1854198: Improve handling of descriptions in DynamicForm field components #6054

merged 1 commit into from Jul 27, 2020

Conversation

TheRealJon
Copy link
Member

@TheRealJon TheRealJon commented Jul 21, 2020 •
edited

  • Add description to array and object fields
  • Move description for UpdateStrategy just below the label
  • Move FieldSet and FormField components into fields.tsx file to eliminate dependency cycle
  • Refine prop types for FieldSet and FormField components
  • Remove spread operator from field and template components

1854198-bz

cc @openshift/team-ux-review @tlwu2013

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 21, 2020
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: This pull request references Bugzilla bug 1854198, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1854198: Improve handling of descriptions in DynamicForm field components

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the component/shared Related to console-shared label Jul 21, 2020
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: This pull request references Bugzilla bug 1854198, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1854198: Improve handling of descriptions in DynamicForm field components

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TheRealJon
Copy link
Member Author

/assign @rhamilto

@TheRealJon
Copy link
Member Author

/cherry-pick release-4.5

@openshift-cherrypick-robot
Copy link

@TheRealJon: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TheRealJon
Bug 1854198: Show descriptions for all dynamic form fields
ebc7c33 
Add descriptions for array and object fields generated by DynamicForm component.
@rhamilto
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 35aefdd into openshift:master Jul 27, 2020
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: All pull requests linked via external trackers have merged: openshift/console#6054. Bugzilla bug 1854198 has been moved to the MODIFIED state.

In response to this:

Bug 1854198: Improve handling of descriptions in DynamicForm field components

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@TheRealJon: #6054 failed to apply on top of branch "release-4.5":

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Jul 28, 2020
TheRealJon added a commit to TheRealJon/console that referenced this pull request Jul 28, 2020
@TheRealJon
Bug 1861433: Show descriptions for all dynamic form fields
d442cef 
Manual cherry pick of openshift#6054
@TheRealJon TheRealJon mentioned this pull request Jul 28, 2020
Merged
@TheRealJon TheRealJon deleted the 1854198-bz branch January 28, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto left review comments

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@TheRealJon @openshift-ci-robot @openshift-cherrypick-robot @rhamilto @openshift-bot @spadgett @openshift-merge-robot