Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gherkin_script: Display failure details on pipeline run details #6062

Merged

Conversation

sanketpathak
Copy link
Contributor

Copy link
Contributor

@gajanan-more gajanan-more left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the extension to this file.

@sanketpathak sanketpathak force-pushed the gherkin_script_ODC-3713 branch 2 times, most recently from 56d88d8 to c0f82ca Compare July 23, 2020 21:40
@regression
Scenario: Display failure details of pipeline run in topology sidebar
Given user is in topology
And a node with failed pipeline is present
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how much assumption here is... but did we want to say what "node with failed pipeline" is? Like

Suggested change
And a node with failed pipeline is present
And a node with an associated pipeline that has failed is present

Scenario: Display failure details of pipeline run in topology sidebar
Given user is in topology
And a node with failed pipeline is present
When user opens sidebar of the n ode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When user opens sidebar of the n ode
When user opens sidebar of the node

And user scrolls down to pipeline runs section
Then user will see the pipeline run name with failed status
And user will see failure message below pipeline runs
And user will also see the log snippet with horizontal scroller
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically there is nothing saying it has to have a horizontal scroller. It is technically possible not to have it.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2020
@gajanan-more
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, gajanan-more, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7def122 into openshift:master Jul 26, 2020
@spadgett spadgett added this to the v4.6 milestone Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants