Add RGW Support in Object Service Dashboard #6070

bipuladh · 2020-07-22T12:14:09Z

Add Support for RGW in Top Consumers Card
Add Support for Performance Card
Added Dashboard upgrade for RGW

bipuladh · 2020-07-22T22:32:44Z

...ackages/noobaa-storage-plugin/src/components/data-consumption-card/data-consumption-card.tsx

-    curentDropdown,
+  const parser = React.useMemo(
+    () =>
+      // Todo (bipuladh): Fix data consumption utils to work with getInstantVectorStats


Won't be doing as part of 4.6.

bipuladh · 2020-07-22T22:33:12Z

...ackages/noobaa-storage-plugin/src/components/data-consumption-card/data-consumption-card.tsx

+          setSelectedBreakdown={setBreakdownBy}
+          selectedMetric={metric}
+          setSelectedMetric={setMetric}
+          isRgwSupported


@anmolsachan we need to determine where we are going to support it and where not.

gnehapk · 2020-07-23T05:45:55Z

...ceph-storage-plugin/src/components/dashboard-page/storage-dashboard/breakdown-card/utils.tsx

-      name: _.truncate(`${r.x}`, { length: 12 }),
-      link: `${r.x}`,
-      color: Colors.LINK,
+      name: labelNames ? labelNames[i] : _.truncate(`${r.x}`, { length: 12 }),


A question here - Shouldn't you be checking labelNames[i] too here, before applying it in case labelNames[i] is undefined?

No need as there a few cases where we pass label names and for those cases, we can put the correct number of items, in the array. I have created a map for those special cases.

gnehapk · 2020-07-23T05:51:55Z

frontend/packages/console-shared/src/components/dashboard/utilization-card/prometheus-hook.ts


  return results;
 };

 type UsePrometheusQuery = (query: string, humanize: Humanize) => [HumanizeResult, any, number];
-type UsePrometheusQueries = (queries: string[], metric?: string) => UsePrometheusQueriesResult;
-type UsePrometheusQueriesResult = [DataPoint[], boolean, any][];
+// [data, loading, loadError]


Why this comment here?

To make people aware of difference between loading and loaded. I see some interfaces using loading and some using loaded.

...ackages/noobaa-storage-plugin/src/components/capacity-breakdown/capacity-breakdown-card.scss

gnehapk · 2020-07-23T05:59:54Z

...packages/noobaa-storage-plugin/src/components/capacity-breakdown/capacity-breakdown-card.tsx

-      queryKeys.forEach((q) => stopWatchPrometheusQuery(queries[q]));
-    };
-  }, [watchPrometheus, stopWatchPrometheusQuery, metricType, queryKeys, queries]);
+const getDisablableSelectOptions = (dropdownItems: DropdownItems) => {


typo getDisableableSelectOptions

gnehapk · 2020-07-23T06:03:22Z

...packages/noobaa-storage-plugin/src/components/capacity-breakdown/capacity-breakdown-card.tsx

+            selections={[serviceType]}
+            isGrouped
+            placeholderText={`Type: ${serviceType}`}
+            isCheckboxSelectionBadgeHidden


Please add id

gnehapk · 2020-07-23T06:03:48Z

...packages/noobaa-storage-plugin/src/components/capacity-breakdown/capacity-breakdown-card.tsx

+            isOpen={isOpenBreakdownSelect}
+            selections={[metricType]}
+            isGrouped
+            placeholderText={`By: ${serviceType}`}


Please add id

gnehapk · 2020-07-23T06:08:19Z

...ackages/noobaa-storage-plugin/src/components/data-consumption-card/data-consumption-card.tsx

+          setSelectedBreakdown={setBreakdownBy}
+          selectedMetric={metric}
+          setSelectedMetric={setMetric}
+          isRgwSupported


isRgwSupported -> isRGWSupported might be better

rawagner · 2020-07-23T08:35:14Z

frontend/packages/console-app/src/components/dashboards-page/status.ts

  componentsHealth: SubsystemHealth[],
 ): { state: HealthState; message: string; count: number } => {
-  const withPriority = componentsHealth.map((h) => healthPriority[h.state]);
+  const withPriority = componentsHealth.map((h) => healthPriority?.[h.state] ?? {});


no need for healthPriority?.[h.state]

Suggested change

const withPriority = componentsHealth.map((h) => healthPriority?.[h.state] ?? {});

const withPriority = componentsHealth.map((h) => healthPriority[h.state] ?? {});

rawagner · 2020-07-23T08:35:43Z

frontend/packages/console-app/src/components/dashboards-page/status.ts

  componentsHealth: SubsystemHealth[],
 ): { state: HealthState; message: string; count: number } => {
-  const withPriority = componentsHealth.map((h) => healthPriority[h.state]);
+  const withPriority = componentsHealth.map((h) => healthPriority?.[h.state] ?? {});
  const mostImportantState = Math.max(...withPriority.map(({ priority }) => priority));


Maybe even better and less error prone would be to make sure that healthPriority contains all Health States. Currently its lacking Loading state. Once we add it I think there's no reason to have separate healthStateMapping and healthPriority. We just include the priority into healthStateMapping directly.

export const healthStateMapping: { [key in HealthState]: PriorityHealthState } = { [HealthState.OK]: { priority: 0, health: HealthState.OK, icon: <GreenCheckCircleIcon />, }, [HealthState.UNKNOWN]: { priority: 1, health: HealthState.UNKNOWN, icon: <GrayUnknownIcon />, message: 'Unknown', }, [HealthState.PROGRESS]: { priority: 2, health: HealthState.PROGRESS, icon: <InProgressIcon />, message: 'Pending', }, [HealthState.UPDATING]: { priority: 3, health: HealthState.UPDATING, icon: <BlueSyncIcon />, message: 'Updating', }, [HealthState.WARNING]: { priority: 4, health: HealthState.WARNING, icon: <YellowExclamationTriangleIcon />, message: 'Degraded', }, [HealthState.ERROR]: { priority: 5, health: HealthState.ERROR, icon: <RedExclamationCircleIcon />, message: 'Degraded', }, [HealthState.LOADING]: { priority: 6, health: HealthState.LOADING, icon: <div className="skeleton-health" />, }, [HealthState.NOT_AVAILABLE]: { priority: 7, health: HealthState.NOT_AVAILABLE, icon: <GrayUnknownIcon />, message: 'Not available', }, };

Can you try that ?

mykaul · 2020-07-23T15:02:31Z

Just looking at the screenshot - 'RADOS' is a terminology / details, we wish to expose to the customer? What's the benefit?

cloudbehl · 2020-07-23T15:06:12Z

Just looking at the screenshot - 'RADOS' is a terminology / details, we wish to expose to the customer? What's the benefit?

@yuvalgalanti ^^

gnehapk · 2020-07-24T04:25:46Z

...ckages/noobaa-storage-plugin/src/components/data-consumption-card/data-consumption-graph.tsx

+import { getDataConsumptionChartData, numberInWords } from './data-consumption-card-utils';
+import { DATA_CONSUMPTION_QUERIES } from '../../queries';
+import './data-consumption-card.scss';
+import { PrometheusResponse } from '@console/internal/components/graphs';


This import should be moved before the relative ones.

bipuladh · 2020-07-27T09:58:44Z

patternfly/patternfly-react#4604

rawagner · 2020-07-27T10:23:52Z

frontend/packages/console-shared/src/components/dashboard/status-card/states.tsx

  },
 };

+type HealthStateMappingKeys = keyof typeof HealthState;
 export type PriorityHealthState = {


seems like we dont need this one anymore as its the same as HealthStateMappingValues

rawagner · 2020-07-27T10:36:39Z

/approve

cloudbehl · 2020-07-27T11:49:23Z

frontend/packages/ceph-storage-plugin/src/features.ts

+        clearInterval(id);
+      }
+    });
+  id = setInterval(logicHandler, 10000);


nit: create variable for SECOND

Suggested change

id = setInterval(logicHandler, 10000);

id = setInterval(logicHandler, 10* SECOND);

cloudbehl · 2020-07-27T11:56:32Z

frontend/packages/ceph-storage-plugin/src/features.ts

+      const provisioners = data.map((sc) => sc.provisioner);
+      if (provisioners.includes('openshift-storage.ceph.rook.io/bucket')) {


const cephRGWProvisioner = 'openshift-storage.ceph.rook.io/bucket'; const checkRGWSCIsPresent = () => data.some((sc) => sc.provisioner === cephRGWProvisioner); if(checkRGWSCIsPresent) { ... }

Probably use const file to define variable & checkRGWSCIsPresent in utils & can be used later for checks.

cloudbehl · 2020-07-28T17:45:31Z

/lgtm

Add Support for Performance Card Added Dashboard upgrade for RGW

cloudbehl · 2020-07-29T05:54:32Z

/lgtm

openshift-ci-robot · 2020-07-29T05:54:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, cloudbehl, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-07-29T05:56:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-29T06:09:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-29T07:53:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-29T09:24:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. component/ceph Related to ceph-storage-plugin labels Jul 22, 2020

openshift-ci-robot requested review from kyoto and rawagner July 22, 2020 12:14

openshift-ci-robot added component/core Related to console core functionality component/dashboard Related to dashboard component/noobaa Related to noobaa-storage-plugin component/shared Related to console-shared labels Jul 22, 2020

bipuladh changed the title ~~[WIP] Add Health Status Popovers for Status Card for RGW~~ [WIP] Add RGW Support in Object Service Dashboard Jul 22, 2020

bipuladh force-pushed the rgw_work branch 4 times, most recently from 5753225 to 20ab6fe Compare July 22, 2020 22:43

bipuladh commented Jul 22, 2020

View reviewed changes

bipuladh changed the title ~~[WIP] Add RGW Support in Object Service Dashboard~~ Add RGW Support in Object Service Dashboard Jul 22, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2020

bipuladh force-pushed the rgw_work branch from 20ab6fe to e359d92 Compare July 22, 2020 23:03

gnehapk reviewed Jul 23, 2020

View reviewed changes

...ackages/noobaa-storage-plugin/src/components/capacity-breakdown/capacity-breakdown-card.scss Show resolved Hide resolved

gnehapk reviewed Jul 23, 2020

View reviewed changes

rawagner reviewed Jul 23, 2020

View reviewed changes

gnehapk reviewed Jul 24, 2020

View reviewed changes

bipuladh force-pushed the rgw_work branch from e359d92 to b5eccf1 Compare July 27, 2020 09:55

openshift-ci-robot added the component/olm Related to OLM label Jul 27, 2020

bipuladh force-pushed the rgw_work branch 2 times, most recently from 9d3cb12 to b604551 Compare July 27, 2020 10:03

rawagner suggested changes Jul 27, 2020

View reviewed changes

bipuladh force-pushed the rgw_work branch from b604551 to 50bfe3d Compare July 27, 2020 10:35

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2020

cloudbehl reviewed Jul 27, 2020

View reviewed changes

bipuladh force-pushed the rgw_work branch from 50bfe3d to d21831d Compare July 28, 2020 15:41

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2020

bipuladh force-pushed the rgw_work branch from d21831d to 653b7e4 Compare July 28, 2020 15:52

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2020

openshift-ci-robot assigned cloudbehl Jul 28, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020

Add Support for RGW in Top Consumers Card

be05ebb

Add Support for Performance Card Added Dashboard upgrade for RGW

bipuladh force-pushed the rgw_work branch from 653b7e4 to be05ebb Compare July 28, 2020 17:47

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2020

openshift-merge-robot merged commit c353047 into openshift:master Jul 29, 2020

spadgett added this to the v4.6 milestone Jul 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add RGW Support in Object Service Dashboard #6070

Add RGW Support in Object Service Dashboard #6070

bipuladh commented Jul 22, 2020 •

edited

bipuladh Jul 22, 2020

bipuladh Jul 22, 2020

gnehapk Jul 23, 2020

bipuladh Jul 23, 2020

gnehapk Jul 23, 2020

bipuladh Jul 23, 2020

gnehapk Jul 23, 2020 •

edited

gnehapk Jul 23, 2020

gnehapk Jul 23, 2020

gnehapk Jul 23, 2020

rawagner Jul 23, 2020

rawagner Jul 23, 2020

mykaul commented Jul 23, 2020

cloudbehl commented Jul 23, 2020

gnehapk Jul 24, 2020

bipuladh commented Jul 27, 2020

rawagner Jul 27, 2020

rawagner commented Jul 27, 2020

cloudbehl Jul 27, 2020

cloudbehl Jul 27, 2020

cloudbehl Jul 27, 2020

cloudbehl commented Jul 28, 2020

cloudbehl commented Jul 29, 2020

openshift-ci-robot commented Jul 29, 2020

openshift-bot commented Jul 29, 2020

openshift-bot commented Jul 29, 2020

openshift-bot commented Jul 29, 2020

openshift-bot commented Jul 29, 2020

	const withPriority = componentsHealth.map((h) => healthPriority?.[h.state] ?? {});
	const withPriority = componentsHealth.map((h) => healthPriority[h.state] ?? {});

	id = setInterval(logicHandler, 10000);
	id = setInterval(logicHandler, 10* SECOND);

		const provisioners = data.map((sc) => sc.provisioner);
		if (provisioners.includes('openshift-storage.ceph.rook.io/bucket')) {

Add RGW Support in Object Service Dashboard #6070

Add RGW Support in Object Service Dashboard #6070

Conversation

bipuladh commented Jul 22, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gnehapk Jul 23, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mykaul commented Jul 23, 2020

cloudbehl commented Jul 23, 2020

Choose a reason for hiding this comment

bipuladh commented Jul 27, 2020

Choose a reason for hiding this comment

rawagner commented Jul 27, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cloudbehl commented Jul 28, 2020

cloudbehl commented Jul 29, 2020

openshift-ci-robot commented Jul 29, 2020

openshift-bot commented Jul 29, 2020

openshift-bot commented Jul 29, 2020

openshift-bot commented Jul 29, 2020

openshift-bot commented Jul 29, 2020

bipuladh commented Jul 22, 2020 •

edited

gnehapk Jul 23, 2020 •

edited