Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds kebab option for edit URI along with associated action modal #6074

Merged
merged 1 commit into from Jul 24, 2020
Merged

adds kebab option for edit URI along with associated action modal #6074

merged 1 commit into from Jul 24, 2020

Conversation

invincibleJai
Copy link
Member

@invincibleJai invincibleJai commented Jul 22, 2020 •
edited

Fixes:
https://issues.redhat.com/browse/ODC-4292

Task: https://issues.redhat.com/browse/ODC-4362

Analysis / Root cause:
User can't editURi on Topology as there is not kebab action on sidebar or context menu on topology

Solution Description:
Added kebab action on sidebar or context menu on topology to edit URI

Screen shots / Gifs for design review:

  • Modal
    image

  • Sidebar & contextMenu
    image

@openshift/team-devconsole-ux

Unit test coverage report:
image

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the component/knative Related to knative-plugin label Jul 22, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020
sahil143
sahil143 reviewed Jul 22, 2020
View reviewed changes
frontend/packages/knative-plugin/src/components/sink-uri/SinkUriModal.tsx Outdated
const fieldId = getFieldId('sink-name', 'uri');
const dirty = values?.uri !== initialValues.uri;
return (
<form className="modal-content modal-content--no-inner-scroll" onSubmit={handleSubmit}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use <Form /> from patternfly?

frontend/packages/knative-plugin/src/components/sink-uri/SinkUri.tsx Outdated
onReset={cancel}
initialStatus={{ error: '' }}
>
{(formikProps) => <SinkUriModal {...formikProps} labelTitle="Edit URI" cancel={cancel} />}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set labelTitle directly as modal title, no need to pass as prop. WDYT?

frontend/packages/knative-plugin/src/topology/components/knativeComponentFactory.ts Outdated
@@ -53,6 +54,7 @@ import {
pubSubDropTargetSpec,
CREATE_PUB_SUB_CONNECTOR_OPERATION,
} from './knativeComponentUtils';
// import { element } from 'protractor';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment

@jeff-phillips-18
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@invincibleJai
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit cfd7ff4 into openshift:master Jul 24, 2020
@spadgett spadgett added this to the v4.6 milestone Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahil143 sahil143 sahil143 left review comments

@jeff-phillips-18 jeff-phillips-18 jeff-phillips-18 approved these changes

@andrewballantyne andrewballantyne Awaiting requested review from andrewballantyne

@christianvogt christianvogt Awaiting requested review from christianvogt

Assignees

@jeff-phillips-18 jeff-phillips-18

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/knative Related to knative-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@invincibleJai @jeff-phillips-18 @openshift-ci-robot @openshift-bot @sahil143 @spadgett @openshift-merge-robot