Add Trigger and Subscription modal in topology

[karthikjeeyar]

Fixes: https://issues.redhat.com/browse/ODC-4246 , https://issues.redhat.com/browse/ODC-4167

Problem:
Ability to add trigger/subscription from topology gestures and kebab actions

Solution:
Added Trigger modal and kebab actions for triggers.
Added Subscription modal and kebab actions for subscriptions
Added context menu on the resource backed edges

Note: Sidebar enhancements will be added in a follow up PR

Screenshot:
Trigger Modal:

Subscription Modal:

Empty state:

Error state:

Gif:

cc: @rachael-phillips @beaumorley @openshift/team-devconsole-ux

[karthikjeeyar]

/assign @invincibleJai

[karthikjeeyar]

/retest

[serenamarie125]

@rachael-phillips can you confirm? I think that the label on the Add Trigger modal should be "Subscriber", not "Select Subscriber"

[serenamarie125]

Can we have the Attribute/Value be the same width as the other input widgets? Right now there's extra space between the delete icon & the edge of the modal.

[karthikjeeyar]

@rachael-phillips can you confirm? I think that the label on the Add Trigger modal should be "Subscriber", not "Select Subscriber"

@serenamarie125 @rachael-phillips Like we have in Design doc, I have changed the title to Subscriber and updated the screenshots. The filter attributes section in the trigger modal uses the nameValueEditor field that we use every where in console has this type of spacing.
eg: ApiServersource, sinkbinding event source forms

cc: @christianvogt

[rachael-phillips]

Hey @karthikjeeyar @serenamarie125 I can confirm that the recommendation to have Subscriber rather than Select Subscriber is correct. I think we should eventually update the spacing of the ATTRIBUTE, KEY, VALUE, APIVERSION, KIND, etc. form fields across the flow, but agree with keeping it standard for now rather than updating based on what I've seen in other places. For example, this is another modal on the topology view, and for consistency I think we should go with the standard spacing. To be super clear, I think what Karthik has now for spacing these form fields is correct.

@serenamarie125 I will add your recommendation to this Audit I am currently working on of our form fields so we can address this in the future: https://docs.google.com/document/d/10QMFBrCGmwbq92Vy8GSNteAX6EgslTcR4PnMoQwF_1w/edit?usp=sharing

[christianvogt]

@karthikjeeyar ran into an issue where if I set only the value of a filter and then submit the form, I get an error and then the filters key, value, and Add button go missing.

[christianvogt]

The rest seems to function well.

[rachael-phillips]

LGTM!

[invincibleJai]

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [invincibleJai]
• frontend/packages/knative-plugin/OWNERS [invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[invincibleJai]

Verified , works as expected!!

[karthikjeeyar]

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.