New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let getprovisionsourcestorage read state #6090

Merged

openshift-merge-robot merged 2 commits into openshift:master from yaacov:kubevirt-vm-wizard-let-getprovisionsourcestorage-read-state

Jul 25, 2020

Member

yaacov commented Jul 24, 2020

getProvisionSourceStorage method will need to fetch golden images and common templates from current state

Part of: #5977


          let getprovisionsourcestorage read start

d95ffea

openshift-ci-robot added the component/kubevirt label

openshift-ci-robot requested review from jelkosz and atiratree

July 24, 2020 06:09

openshift-ci-robot added the approved label

atiratree reviewed

View reviewed changes

...virt-plugin/src/components/create-vm-wizard/redux/initial-state/storage-tab-initial-state.ts Outdated

-                provisionSource: ProvisionSource,
-                iStorageClassConfigMap: any,
-              ): VMWizardStorage => {
+              export const getProvisionSourceStorage = (state: any, id: string): VMWizardStorage => {

Member

atiratree Jul 24, 2020

we already have a similar method which is doing something different (iGetProvisionSourceStorage). Can we rename this to getNewProvisionSourceStorage ?

Member Author

yaacov Jul 24, 2020

sure 👍 done

...lugin/src/components/create-vm-wizard/redux/state-update/prefill-vm-template-state-update.ts Outdated

-                    iGetProvisionSource(state, id),
-                    iGetLoadedCommonData(state, id, VMWizardProps.storageClassConfigMap),
-                  );
+                  const newSourceStorage = getProvisionSourceStorage(state, id);

Member

atiratree Jul 24, 2020

+1 this simplifies it nicely


          rename getProvisionSourceStorage to getNewProvisionSourceStorage

a43bbd3

Member Author

yaacov commented Jul 24, 2020

/test e2e-gcp-console

Member

atiratree commented Jul 24, 2020

/lgtm

openshift-ci-robot assigned atiratree

openshift-ci-robot added the lgtm label

Contributor

openshift-ci-robot commented Jul 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suomiy, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/kubevirt-plugin/OWNERS~~ [suomiy,yaacov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Member Author

yaacov commented Jul 24, 2020

/retest

1 similar comment

Member Author

yaacov commented Jul 24, 2020

/retest

Contributor

openshift-bot commented Jul 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments

Contributor

openshift-bot commented Jul 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot merged commit e72f7e6 into openshift:master

spadgett added this to the v4.6 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment