update moveSink modal to support URI along with resources #6094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
invincibleJai
force-pushed
the
update-move-sink
branch
2 times, most recently
from
1197751
to
90d4ddb
Compare
invincibleJai
force-pushed
the
update-move-sink
branch
from
90d4ddb
to
c03f22e
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bgliwa01, christianvogt, invincibleJai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://issues.redhat.com/browse/ODC-4292
Task: https://issues.redhat.com/browse/ODC-4383
Analysis / Root cause:
Move connector/Sink for eventSource and it's connector currently just show dropdown to select ksvc/channel/broker , would need to have URI as well as we have in Create EventSources
Solution Description:
Move Connectorto beMove Sinkas they serve same purposeScreen shots / Gifs for design review:
Move Sink Resource
Move Sink URI
Move Sink in-context
Error State (In case of no Resources
Error state (in case of invalid URI)
@openshift/team-devconsole-ux
Unit test coverage report:
Browser conformance: