Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1859256: Fix blank page/error on ImageManifestVulnPage #6119

Merged
merged 1 commit into from Aug 20, 2020
Merged

Bug 1859256: Fix blank page/error on ImageManifestVulnPage #6119

merged 1 commit into from Aug 20, 2020

Conversation

rebeccaalpert
Copy link
Contributor

There was no check for an undefined props.match in ImageManifestVulnPage, leading to a blank page/error message. Adding a check seems to fix the issue.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1859256.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 27, 2020
@openshift-ci-robot
Copy link
Contributor

@rebeccaalpert: This pull request references Bugzilla bug 1859256, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1859256: Fix blank page/error on ImageManifestVulnPage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2020
@spadgett
Copy link
Member

/assign

@rebeccaalpert
Copy link
Contributor Author

I updated the namespace parameter to use props.namespace. It seems to fix the issue and allow for the correct behavior.

@rebeccaalpert
Bug 1859256: Fix error on imagemanifestvuln list page
d71f57a 
There was no check for an undefined props.match in ImageManifestVulnPage, leading to a blank page/error message. I switched it out for props.namespace instead.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1859256
spadgett
spadgett approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@spadgett
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 20, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebeccaalpert, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2020
@spadgett spadgett added this to the v4.6 milestone Aug 20, 2020
@spadgett
Copy link
Member

/cherry-pick release-4.5

@openshift-cherrypick-robot
Copy link

@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit a3cd752 into openshift:master Aug 20, 2020
@openshift-ci-robot
Copy link
Contributor

@rebeccaalpert: All pull requests linked via external trackers have merged: openshift/console#6119. Bugzilla bug 1859256 has been moved to the MODIFIED state.

In response to this:

Bug 1859256: Fix blank page/error on ImageManifestVulnPage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 20, 2020
Merged
@openshift-cherrypick-robot
Copy link

@spadgett: new pull request created: #6392

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rebeccaalpert @openshift-ci-robot @spadgett @openshift-cherrypick-robot @openshift-merge-robot