Bug 1850513: Disable stop action in VM menu for in process CDI imports #6121
Conversation
openshift-ci-robot
added
the
bugzilla/severity-low
|
@pcbailey: This pull request references Bugzilla bug 1850513, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pcbailey, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@pcbailey: All pull requests linked via external trackers have merged: openshift/console#6121. Bugzilla bug 1850513 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| const title = 'Stop Virtual Machine'; | ||
| return { | ||
| isDisabled: vmStatusBundle?.status?.isPending(), |
There was a problem hiding this comment.
why not use isImporting instead? isPending has overlap with VMI_WAITING which does not have anything to do with importing flow.
Plus this does not include for example CDI_IMPORTING.
also just to be sure (not really against it) are we really introducing isDisabled semantic into our actions? user's are used to having only actions which they can execute.
There was a problem hiding this comment.
I discussed the issue with @matthewcarleton and he would like to move toward disabling actions that are unavailable. I understand both perspectives, but think this is an issue worth discussing further either in a meeting or via some other venue than these comments to make sure it gets the discussion it deserves. Thoughts?
Regarding which status(es) I'm disabling here, I see your point. I'm currently working on https://bugzilla.redhat.com/show_bug.cgi?id=1843532, which is somewhat related. I will include any updates in that PR and let you know when it's posted so we can discuss further, if needed.
There was a problem hiding this comment.
I discussed the issue with @matthewcarleton and he would like to move toward disabling actions that are unavailable. I understand both perspectives, but think this is an issue worth discussing further either in a meeting or via some other venue than these comments to make sure it gets the discussion it deserves. Thoughts?
sure, we can discuss it in a meeting
Regarding which status(es) I'm disabling here, I see your point. I'm currently working on https://bugzilla.redhat.com/show_bug.cgi?id=1843532, which is somewhat related. I will include any updates in that PR and let you know when it's posted so we can discuss further, if needed.
+1
Backend does not support stopping VMs that are still importing. This PR disables the stop action during the import process.