Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update upstream-community-operators image for test #6122

Merged
merged 2 commits into from Jul 29, 2020
Merged

Update upstream-community-operators image for test #6122

merged 2 commits into from Jul 29, 2020

Conversation

ecordell
Copy link
Contributor

@ecordell ecordell commented Jul 27, 2020 •
edited

The existing image does not have some of the newer apis required by OLM.

This now points to quay.io/operator-framework/upstream-community-operators:221f356, which was just rebuilt off of the latest operator-registry base image.

spadgett
spadgett approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 27, 2020
@spadgett
Copy link
Member

/lgtm cancel

The test failure looks legitimate :/ The tests are expecting "Jaeger Tracing" as the operator name, but the name is "Community Jaeger Operator" instead. There might be other changes needed as well.

https://github.com/spadgett/console/blob/fe8e7935b3a281a62c689d1accf1a890be3e33b2/frontend/packages/operator-lifecycle-manager/integration-tests/scenarios/global-installmode.scenario.ts#L104

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_console/6122/pull-ci-openshift-console-master-e2e-gcp-console/1287860972832165888/artifacts/e2e-gcp-console/gui_test_screenshots/1deffc80881150722e8dc475398f60fb.png

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 27, 2020
@ecordell ecordell force-pushed the patch-1 branch 2 times, most recently from 3942087 to f5e4173 Compare July 28, 2020 15:04
@spadgett
Copy link
Member

@ecordell Tests expect name my-jaeger instead of jaeger-all-in-one-inmemory.

https://github.com/openshift/console/blob/master/frontend/packages/operator-lifecycle-manager/integration-tests/scenarios/global-installmode.scenario.ts#L31

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_console/6122/pull-ci-openshift-console-master-e2e-gcp-console/1288128181701709824/artifacts/e2e-gcp-console/gui_test_screenshots/f79650e5d04d0d9593613eaf3ab98ae1.png

spadgett
spadgett approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@ecordell
Update upstream-community-operators image for test
56b9f93 
The existing image does not have some of the newer apis required by OLM.
@ecordell @spadgett
Update frontend/packages/operator-lifecycle-manager/integration-tests…
cb6ed27 
…/scenarios/single-installmode.scenario.ts

Co-authored-by: Sam Padgett <spadgett@redhat.com>
spadgett
spadgett approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 85c26c2 into openshift:master Jul 29, 2020
@spadgett spadgett added this to the v4.6 milestone Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ecordell @spadgett @openshift-ci-robot @openshift-bot @openshift-merge-robot