Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added disk list for BM/Attached devices OCS install #6123

Merged
merged 1 commit into from Jul 29, 2020

Conversation

gnehapk
Copy link
Contributor

@gnehapk gnehapk commented Jul 28, 2020

Added -

  1. Disk List view for OCS install
  2. Handled CLI scenario for auto discovery CR

Screenshot from 2020-07-28 17-16-52

@openshift-ci-robot openshift-ci-robot added the component/ceph Related to ceph-storage-plugin label Jul 28, 2020
@openshift-ci-robot openshift-ci-robot added component/lso Related to local-storage-operator-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2020
@gnehapk gnehapk force-pushed the disk-list branch 4 times, most recently from 278d9c7 to 63d59c5 Compare July 28, 2020 08:26
@gnehapk gnehapk force-pushed the disk-list branch 3 times, most recently from 393bc12 to fcb74a7 Compare July 28, 2020 09:59
@cloudbehl
Copy link
Contributor

/lgtm

@gnehapk
Copy link
Contributor Author

gnehapk commented Jul 29, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

@gnehapk: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afreen23
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, cloudbehl, gnehapk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 72234eb into openshift:master Jul 29, 2020
@spadgett spadgett added this to the v4.6 milestone Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/lso Related to local-storage-operator-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants