(feat): Add OCS kebab actions in the LSO disk inventory related to the day2 operations #6124

afreen23 · 2020-07-28T06:19:01Z

Adds the disk replacement action
Utilizes flag for attached devices cluster (OCS_ATTACHED_DEVICES) to enable the OCS kebab actions
Implements https://issues.redhat.com/browse/RHSTOR-1197

View when OCS_ATTACHED_DEVICES is enabled with OCS based Kebab Actions:

frontend/packages/local-storage-operator-plugin/src/components/disks-list/disks-list-page.tsx

afreen23 · 2020-07-28T07:11:10Z

For the time being I have removed troubleshoot action as kebab action. It will be right to bring it back as popover in a followup PR.

...ge-plugin/src/components/attached-devices-mode/lso-disk-inventory/disk-replacement-modal.tsx

gnehapk · 2020-07-28T10:07:18Z

frontend/packages/local-storage-operator-plugin/src/components/disks-list/disks-list-page.tsx

@@ -131,13 +155,21 @@ const DisksListPage: React.FC<{ obj: NodeKind }> = (props) => {
          selector: { [LABEL_SELECTOR]: nodeName },
        },
      ]}
+      customData={{
+        diskOsdMap: new Map() /* TBD(Afreen) Will be changed to actual state with this https://issues.redhat.com/browse/RHSTOR-1194  */,


A question - where are you exactly adding values inside diskOsdMap as you are getting the disk name from this Map?

I will add the local state to disk list page which will poll data and the pass it down the children.
Will do as part of mentioned issue, its part of another PR.

rawagner · 2020-07-28T06:54:57Z

...ge-plugin/src/components/attached-devices-mode/lso-disk-inventory/disk-replacement-modal.tsx

+     * TODO:(Afreen) Add validations based on ocs status (part of followup PR)
+     */
+    let template: TemplateKind;
+    k8sGet(TemplateModel, OSD_REMOVAL_TEMPLATE, CEPH_STORAGE_NAMESPACE)


i'd prefer async/await syntax. Makes the flow easier to read.

rawagner · 2020-07-28T06:56:00Z

...ge-plugin/src/components/attached-devices-mode/lso-disk-inventory/disk-replacement-modal.tsx

+  osdId: string;
+} & ModalComponentProps;
+
+type TemplateSecret = K8sResourceCommon & {


just use SecretKind type which we already have

That requires to use data and type , instead I am using stringData .

The type check is enforcing to add those fields

export type SecretKind = { data: { [key: string]: string }; stringData?: { [key: string]: string }; type: string; } & K8sResourceCommon;

so the data and type are actually not required ? I would just make them optional in SecretKind

rawagner · 2020-07-28T10:28:37Z

...storage-plugin/src/components/attached-devices-mode/lso-disk-inventory/ocs-kebab-options.tsx

+    }),
+});
+
+export const OCSKebabOptions: React.FC<{ diskName: string; diskOsdMap: Map<string, string> }> = ({


create a separate type definition from { diskName: string; diskOsdMap: Map<string, string> }

afreen23 · 2020-07-28T13:56:44Z

/assign @rawagner

rawagner · 2020-07-28T14:07:32Z

...ge-plugin/src/components/attached-devices-mode/lso-disk-inventory/disk-replacement-modal.tsx

+    /*
+     * TODO:(Afreen) Add validations based on ocs status (part of followup PR)
+     */
+    instantiatetemplate(osdId)


lets not mix async with then syntax

Suggested change

instantiatetemplate(osdId)

try {

instantiatetemplate(osdId);

close();

} catch (err) {

setError(err.message);

} finally {

setProgress(false);

}

rawagner · 2020-07-28T14:09:44Z

...ge-plugin/src/components/attached-devices-mode/lso-disk-inventory/disk-replacement-modal.tsx

+  osdId: string;
+} & ModalComponentProps;
+
+type TemplateSecret = K8sResourceCommon & {


so the data and type are actually not required ? I would just make them optional in SecretKind

…e day2 operations - Adds the disk replacement action - Utilizes flag for attached devices cluster (`OCS_ATTACHED_DEVICES`) to enable the OCS kebab actions Implements https://issues.redhat.com/browse/RHSTOR-1197 Signed-off-by: Afreen Rahman <afrahman@redhat.com>

afreen23 · 2020-07-28T14:36:02Z

@rawagner addressed the reviews.

rawagner · 2020-07-29T06:02:14Z

/lgtm

openshift-ci-robot · 2020-07-29T06:02:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, gnehapk, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot requested review from cloudbehl and gnehapk July 28, 2020 06:19

openshift-ci-robot added component/ceph Related to ceph-storage-plugin component/lso Related to local-storage-operator-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2020

afreen23 commented Jul 28, 2020

View reviewed changes

frontend/packages/local-storage-operator-plugin/src/components/disks-list/disks-list-page.tsx Show resolved Hide resolved

afreen23 force-pushed the disk-replacement-kebab-action branch from de46cc3 to f6f2a40 Compare July 28, 2020 07:02

afreen23 force-pushed the disk-replacement-kebab-action branch from f6f2a40 to 59020ee Compare July 28, 2020 07:40

gnehapk reviewed Jul 28, 2020

View reviewed changes

...ge-plugin/src/components/attached-devices-mode/lso-disk-inventory/disk-replacement-modal.tsx Show resolved Hide resolved

afreen23 force-pushed the disk-replacement-kebab-action branch from 59020ee to 2134508 Compare July 28, 2020 09:51

gnehapk reviewed Jul 28, 2020

View reviewed changes

rawagner suggested changes Jul 28, 2020

View reviewed changes

afreen23 force-pushed the disk-replacement-kebab-action branch 2 times, most recently from ada1b9e to 0c63c1c Compare July 28, 2020 11:55

gnehapk approved these changes Jul 28, 2020

View reviewed changes

openshift-ci-robot assigned rawagner Jul 28, 2020

rawagner suggested changes Jul 28, 2020

View reviewed changes

afreen23 force-pushed the disk-replacement-kebab-action branch from 0c63c1c to 864b145 Compare July 28, 2020 14:35

openshift-ci-robot added component/core Related to console core functionality and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2020

openshift-merge-robot merged commit c116d89 into openshift:master Jul 29, 2020

spadgett added this to the v4.6 milestone Jul 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(feat): Add OCS kebab actions in the LSO disk inventory related to the day2 operations #6124

(feat): Add OCS kebab actions in the LSO disk inventory related to the day2 operations #6124

afreen23 commented Jul 28, 2020 •

edited

afreen23 commented Jul 28, 2020

gnehapk Jul 28, 2020

afreen23 Jul 28, 2020 •

edited

rawagner Jul 28, 2020

rawagner Jul 28, 2020

afreen23 Jul 28, 2020 •

edited

afreen23 Jul 28, 2020

afreen23 Jul 28, 2020

rawagner Jul 28, 2020

rawagner Jul 28, 2020

afreen23 commented Jul 28, 2020

rawagner Jul 28, 2020

rawagner Jul 28, 2020

afreen23 commented Jul 28, 2020

rawagner commented Jul 29, 2020

openshift-ci-robot commented Jul 29, 2020

-    instantiatetemplate(osdId)
+    try {
+      instantiatetemplate(osdId);
+      close();
+    } catch (err) {
+      setError(err.message);
+    } finally {
+      setProgress(false);
+    }

(feat): Add OCS kebab actions in the LSO disk inventory related to the day2 operations #6124

(feat): Add OCS kebab actions in the LSO disk inventory related to the day2 operations #6124

Conversation

afreen23 commented Jul 28, 2020 • edited

afreen23 commented Jul 28, 2020

Choose a reason for hiding this comment

afreen23 Jul 28, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afreen23 Jul 28, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afreen23 commented Jul 28, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afreen23 commented Jul 28, 2020

rawagner commented Jul 29, 2020

openshift-ci-robot commented Jul 29, 2020

afreen23 commented Jul 28, 2020 •

edited

afreen23 Jul 28, 2020 •

edited

afreen23 Jul 28, 2020 •

edited