Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start moving PromQL queries to a central location #6128

Merged
merged 1 commit into from Jul 29, 2020
Merged

Start moving PromQL queries to a central location #6128

merged 1 commit into from Jul 29, 2020

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Jul 28, 2020

The intention is to begin moving all of Console's PromQL queries (including those under frontend/packages/) to a central location over time. This will allow the Monitoring team to help with reviewing queries as they are added and modified.

FYI @openshift/openshift-team-monitoring

@kyoto kyoto mentioned this pull request Jul 28, 2020
Merged
@kyoto
Copy link
Member Author

kyoto commented Jul 28, 2020

/retest

@kyoto kyoto closed this Jul 28, 2020
@kyoto kyoto reopened this Jul 28, 2020
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2020
@kyoto kyoto changed the title WIP: Start moving PromQL queries to a central location Start moving PromQL queries to a central location Jul 29, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2020
@kyoto kyoto force-pushed the centralize-promql-queries branch from 4f81f80 to 2361518 Compare July 29, 2020 13:57
spadgett
spadgett approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

thanks @kyoto 👍
@rawagner fyi

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2020
@spadgett
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit ea81fdc into openshift:master Jul 29, 2020
@kyoto kyoto deleted the centralize-promql-queries branch July 29, 2020 23:33
@spadgett spadgett added this to the v4.6 milestone Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kyoto @openshift-ci-robot @spadgett @openshift-merge-robot