New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to hide all groups in topology #6130
Add ability to hide all groups in topology #6130
Conversation
6c4e98e
to
836b568
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when show groups is off, the expand toggle should be disabled - it can stay in the selected state, just needs to be disabled
836b568
to
04da869
Compare
Updated to disable the expand options and added unit tests for them. |
I feel this is a little odd... but I can also bend my brain to understand it. @bgliwa01 By design? |
@andrewballantyne yes this is correct implementation of the design |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @christianvogt |
@andrewballantyne @bgliwa01 Actually it is not the correct implementation. The children should be shown. It should not matter the order in which things were selected. However, there is an issue with PF topology that prevents nodes whose parent no longer exists from being re-rendered to the graph. Have a PR up to fix it: patternfly/patternfly-react#4629 |
@andrewballantyne @jeff-phillips-18 I see what you are saying now, I thought it was around how expand becomes disabled. +1 to everything jeff said |
Can someone explain to me why edges are hidden and creation is disabled when the user chooses to hide groupings? Why are groups and edges even related? |
76050ed
to
05f4a3d
Compare
/retest |
/approve |
05f4a3d
to
a03ab5e
Compare
/lgtm |
Verified locally, seems to work as expected |
a03ab5e
to
a3162f4
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, christianvogt, invincibleJai, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes
https://issues.redhat.com/browse/ODC-4317
Description
As a developer, I want to view my “Grouped Resources” as flat workloads, hiding the grouping, in the Topology View.
In this mode:
Screenshots
Browser conformance:
/kind feature
cc @openshift/team-devconsole-ux @serenamarie125 @beaumorley @bgliwa01