Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to hide all groups in topology #6130

Merged

Conversation

jeff-phillips-18
Copy link
Member

@jeff-phillips-18 jeff-phillips-18 commented Jul 28, 2020

Fixes
https://issues.redhat.com/browse/ODC-4317

Description
As a developer, I want to view my “Grouped Resources” as flat workloads, hiding the grouping, in the Topology View.

In this mode:

  • No groups are shown
  • Children of groups are shown as individual nodes
  • the corresponding workload node for grouped nodes are shown (ie the Revisions for a knative service are shown as well as the deployment that backs it).
  • Edges are not shown
  • Edges are not allowed to be created

Screenshots

FlatGroups

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

/kind feature

cc @openshift/team-devconsole-ux @serenamarie125 @beaumorley @bgliwa01

@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin labels Jul 28, 2020
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toggles operate oddly.

displayOptionToggles

We should disable the 2nd dropdown or make it do the normal operation when show groups is enabled.

Copy link

@bgliwa01 bgliwa01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when show groups is off, the expand toggle should be disabled - it can stay in the selected state, just needs to be disabled

@jeff-phillips-18
Copy link
Member Author

Updated to disable the expand options and added unit tests for them.

@andrewballantyne
Copy link
Contributor

HideGroupsByDesignHideNodes

I feel this is a little odd... but I can also bend my brain to understand it. @bgliwa01 By design?

@bgliwa01
Copy link

HideGroupsByDesignHideNodes

I feel this is a little odd... but I can also bend my brain to understand it. @bgliwa01 By design?

@andrewballantyne yes this is correct implementation of the design

Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2020
@andrewballantyne
Copy link
Contributor

/assign @christianvogt

@jeff-phillips-18
Copy link
Member Author

@andrewballantyne @bgliwa01 Actually it is not the correct implementation. The children should be shown. It should not matter the order in which things were selected. However, there is an issue with PF topology that prevents nodes whose parent no longer exists from being re-rendered to the graph. Have a PR up to fix it: patternfly/patternfly-react#4629

@bgliwa01
Copy link

@andrewballantyne @jeff-phillips-18 I see what you are saying now, I thought it was around how expand becomes disabled. +1 to everything jeff said

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. component/core Related to console core functionality and removed lgtm Indicates that a PR is ready to be merged. labels Jul 29, 2020
@christianvogt
Copy link
Contributor

Can someone explain to me why edges are hidden and creation is disabled when the user chooses to hide groupings? Why are groups and edges even related?

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2020
@jeff-phillips-18
Copy link
Member Author

/retest

@christianvogt
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
@invincibleJai
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@invincibleJai
Copy link
Member

Verified locally, seems to work as expected

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@invincibleJai
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, invincibleJai, jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit cb81046 into openshift:master Jul 31, 2020
@spadgett spadgett added this to the v4.6 milestone Aug 1, 2020
@jeff-phillips-18 jeff-phillips-18 deleted the flat-topology branch December 2, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants