New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitOps application details page #6137
Add GitOps application details page #6137
Conversation
/cc: @rohitkrai03 |
/cc: @serenamarie125 |
e2b3fff
to
1e56b6f
Compare
1e56b6f
to
4a91d42
Compare
frontend/packages/dev-console/src/components/gitops/CommitDetails.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/gitops/CommitDetails.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/gitops/GitOpsDetails.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/gitops/GitOpsDetails.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/gitops/GitOpsDetails.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/gitops/TimestampWrapper.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/gitops/TimestampWrapper.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/gitops/TimestampWrapper.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/gitops/GitOpsServiceDetailsSection.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/gitops/GitOpsServiceDetailsSection.tsx
Outdated
Show resolved
Hide resolved
4a91d42
to
4dbb68f
Compare
@sahil143 Thanks for the review. Seems like most of the comments are for code clean-up which I planned to do after all the pieces were in place. Though most of the work is done now, so I am working on the clean-up. There were some comments in the code because I am interchangeably testing with mock and live data. |
790c19f
to
973fb93
Compare
hey @divyanshiGupta this is looking really good! It seems like there are some inconsistencies with spacing, etc. Are you going to be able to address those before FF or will It be in a follow-on? Glad to see you're able to get 5 env on a page without scrolling 🎉 |
@serenamarie125 I have added the missing spaces already, forgot to update the mock. Will update it now. |
@serenamarie125 updated. |
2b03a7b
to
5144fb4
Compare
@serenamarie125 I have mentioned in the doc that it is possible to have pod-details and not have commit-details or vice-versa. So I think it is better to have two separate empty states for both. Let me know wdyt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm |
@divyanshiGupta: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-gcp-console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great job on this @divyanshiGupta
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyanshiGupta, rohitkrai03, serenamarie125 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-gcp-console |
/retest Please review the full test history for this PR and help us cut down flakes. |
Jira Story - https://issues.redhat.com/browse/ODC-4289
This PR adds GitOps application details page
Screenshot -
Setup for testing the PR -
Install the GitOps operator from https://github.com/redhat-developer/gitops-operator
Note: Use OCP >= v4.5
Fetch the proxy PR
git fetch upstream refs/pull/5928/head && git checkout -b gitops FETCH_HEAD
Build backend to enable the proxy
Create a namespace
kubectl create namespace pipelines-{USERNAME}-github
Create secret with your github token in above namespace
kubectl create secret generic SECRET_NAME --from-literal=token=${GITHUB_TOKEN} -n SECRET_NS
Add the below mentioned annotation in your namespace
app.openshift.io/vcs-uri: https://github.com/rhd-gitops-example/gitops.git
Blockers