Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitOps application details page #6137

Merged

Conversation

divyanshiGupta
Copy link
Contributor

@divyanshiGupta divyanshiGupta commented Jul 28, 2020

Jira Story - https://issues.redhat.com/browse/ODC-4289

This PR adds GitOps application details page

Screenshot -
image

Setup for testing the PR -

  • Install the GitOps operator from https://github.com/redhat-developer/gitops-operator
    Note: Use OCP >= v4.5

  • Fetch the proxy PR
    git fetch upstream refs/pull/5928/head && git checkout -b gitops FETCH_HEAD

  • Build backend to enable the proxy

    source ./contrib/oc-environment.sh
    ./build-backend.sh 
    ./bin/bridge
    
  • Create a namespace
    kubectl create namespace pipelines-{USERNAME}-github

  • Create secret with your github token in above namespace
    kubectl create secret generic SECRET_NAME --from-literal=token=${GITHUB_TOKEN} -n SECRET_NS

  • Add the below mentioned annotation in your namespace
    app.openshift.io/vcs-uri: https://github.com/rhd-gitops-example/gitops.git

Blockers

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. component/dev-console Related to dev-console labels Jul 28, 2020
@divyanshiGupta
Copy link
Contributor Author

/cc: @rohitkrai03

@divyanshiGupta
Copy link
Contributor Author

/cc: @serenamarie125

@divyanshiGupta divyanshiGupta changed the title [WIP]Add GitOps application details page Add GitOps application details page Jul 29, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2020
@divyanshiGupta
Copy link
Contributor Author

divyanshiGupta commented Jul 30, 2020

@sahil143 Thanks for the review. Seems like most of the comments are for code clean-up which I planned to do after all the pieces were in place. Though most of the work is done now, so I am working on the clean-up. There were some comments in the code because I am interchangeably testing with mock and live data.

@divyanshiGupta divyanshiGupta force-pushed the gitops-details branch 2 times, most recently from 790c19f to 973fb93 Compare July 30, 2020 15:50
@serenamarie125
Copy link
Contributor

hey @divyanshiGupta this is looking really good! It seems like there are some inconsistencies with spacing, etc. Are you going to be able to address those before FF or will It be in a follow-on?

Glad to see you're able to get 5 env on a page without scrolling 🎉
FYI @bkrikori

@divyanshiGupta
Copy link
Contributor Author

@serenamarie125 I have added the missing spaces already, forgot to update the mock. Will update it now.

@divyanshiGupta
Copy link
Contributor Author

@serenamarie125 updated.

@divyanshiGupta divyanshiGupta force-pushed the gitops-details branch 4 times, most recently from 2b03a7b to 5144fb4 Compare July 30, 2020 18:45
@serenamarie125
Copy link
Contributor

One more nit, are you able to the empty state before FF as well?
Screen Shot 2020-07-30 at 3 09 54 PM

Beth added a single message which runs the width of the card.

@divyanshiGupta
Copy link
Contributor Author

divyanshiGupta commented Jul 30, 2020

@serenamarie125 I have mentioned in the doc that it is possible to have pod-details and not have commit-details or vice-versa. So I think it is better to have two separate empty states for both. Let me know wdyt.

Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
@rohitkrai03
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020
@openshift-ci-robot
Copy link
Contributor

@divyanshiGupta: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test analyze
  • /test backend
  • /test e2e-gcp-console
  • /test frontend
  • /test images

Use /test all to run all jobs.

In response to this:

/test ci/prow/e2e-gcp-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@divyanshiGupta
Copy link
Contributor Author

/test e2e-gcp-console

Copy link
Contributor

@serenamarie125 serenamarie125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job on this @divyanshiGupta

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyanshiGupta, rohitkrai03, serenamarie125

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@divyanshiGupta
Copy link
Contributor Author

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants