Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue to show Workers progress bar if not 100% when CV is updated #6139

Merged
merged 1 commit into from Jul 29, 2020
Merged

Continue to show Workers progress bar if not 100% when CV is updated #6139

merged 1 commit into from Jul 29, 2020

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Jul 28, 2020 •
edited

88720100-51b99000-d0f2-11ea-92ea-b96cbad83f1f copy

Video of switch: https://youtu.be/KglxwTcOeYI

Bonus fix: update Worker Nodes help icon and popover

@rhamilto rhamilto added this to the v4.6 milestone Jul 28, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@megan-hall
Copy link

lgtm!

@megan-hall
Copy link

One small question - should we just link the word Nodes and not Master Nodes and Worker Nodes - just so it is clear that its the complete Nodes list and not filtered?

Other than that lgtm!!

@rhamilto
Copy link
Member Author

One small question - should we just link the word Nodes and not Master Nodes and Worker Nodes - just so it is clear that its the complete Nodes list and not filtered?

Other than that lgtm!!

The links are to the filtered Nodes list.

spadgett
spadgett approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e2141df into openshift:master Jul 29, 2020
@rhamilto rhamilto deleted the add-workers-to-graph branch July 29, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@spadgett spadgett

@megan-hall megan-hall

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rhamilto @megan-hall @openshift-ci-robot @spadgett @openshift-merge-robot