New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GuidedTour: fix fontsize and color of popover and modal #6153
GuidedTour: fix fontsize and color of popover and modal #6153
Conversation
@@ -0,0 +1,4 @@ | |||
.co-step-badge { | |||
font-size: 14px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sahil143 I just looked at PF font sizes. sm is in fact 14px -
/lgtm verified locally seems to works as expected |
@sahil143 however in design doc , button text is and for Welcome as well as well it doesn't match |
@invincibleJai this doc is outdated from text perspective. Follow this doc for text https://docs.google.com/document/d/1rOeUoPZV8vwzfH9h94WxpzbV-Bc-Qjhjvl3ABrJIUTQ/edit |
@@ -0,0 +1,4 @@ | |||
.co-step-badge { | |||
font-size: 14px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sahil143 I just looked at PF font sizes. sm is in fact 14px -
@rohitkrai03 I tried using sm for the content but it's coming out as 13px. |
That's weird. We probably raise an issue for this on PF. In the mean time it's okay to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This looks great really nice. I think we will need to review that spotlight blue once it is merged for a final approval. But besides that the formatting looks good. Do you have URLs for the blogs and documentation links at the end? I do not think we provided those.
Thank you. |
/approve |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
1 similar comment
/retest |
@beaumorley For Blog and Documentation, I used the same links that are being used in the help menu |
/retest |
1 similar comment
/retest |
fab9e4f
to
85caa90
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, invincibleJai, rohitkrai03, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
1 similar comment
/retest |
Story: https://issues.redhat.com/browse/ODC-4406
This PR Aligns the Guided tour with UX requirements