Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GuidedTour: fix fontsize and color of popover and modal #6153

Merged
merged 1 commit into from Aug 1, 2020

Conversation

sahil143
Copy link
Contributor

Story: https://issues.redhat.com/browse/ODC-4406

This PR Aligns the Guided tour with UX requirements

aligngt

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Jul 30, 2020
@@ -0,0 +1,4 @@
.co-step-badge {
font-size: 14px;
Copy link
Contributor Author

@sahil143 sahil143 Jul 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using values instead of PF variable because
For modal it works fine for the header --pf-global--FontSize--md(16px) but for popover the same variable is of 14px. And for content --pf-global--FontSize--sm is (13px) but needed 14px
Screenshot 2020-07-30 at 11 52 06 AM
Screenshot 2020-07-30 at 11 52 26 AM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sahil143 I just looked at PF font sizes. sm is in fact 14px -
image

@invincibleJai
Copy link
Member

/lgtm

verified locally seems to works as expected

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020
@invincibleJai
Copy link
Member

invincibleJai commented Jul 30, 2020

@sahil143 however in design doc , button text is Got it but here it's Cancel for Confirmation

image

and for Welcome as well as well it doesn't match

image

@sahil143
Copy link
Contributor Author

@invincibleJai this doc is outdated from text perspective. Follow this doc for text https://docs.google.com/document/d/1rOeUoPZV8vwzfH9h94WxpzbV-Bc-Qjhjvl3ABrJIUTQ/edit

@@ -0,0 +1,4 @@
.co-step-badge {
font-size: 14px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sahil143 I just looked at PF font sizes. sm is in fact 14px -
image

@sahil143
Copy link
Contributor Author

@rohitkrai03 I tried using sm for the content but it's coming out as 13px.
Screenshot 2020-07-30 at 3 52 39 PM

@rohitkrai03
Copy link
Contributor

@rohitkrai03 I tried using sm for the content but it's coming out as 13px.
Screenshot 2020-07-30 at 3 52 39 PM

That's weird. We probably raise an issue for this on PF. In the mean time it's okay to use 14px directly.

Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@beaumorley
Copy link

beaumorley commented Jul 30, 2020

This looks great really nice. I think we will need to review that spotlight blue once it is merged for a final approval. But besides that the formatting looks good.

Do you have URLs for the blogs and documentation links at the end? I do not think we provided those.

Thank you.

cc @serenamarie125

@christianvogt
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
@andrewballantyne
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@andrewballantyne
Copy link
Contributor

/retest

1 similar comment
@andrewballantyne
Copy link
Contributor

/retest

@sahil143
Copy link
Contributor Author

This looks great really nice. I think we will need to review that spotlight blue once it is merged for a final approval. But besides that the formatting looks good.

Do you have URLs for the blogs and documentation links at the end? I do not think we provided those.

Thank you.

cc @serenamarie125

@beaumorley For Blog and Documentation, I used the same links that are being used in the help menu Documentation and Openshift Blog menu item.

@sahil143
Copy link
Contributor Author

/retest

1 similar comment
@sahil143
Copy link
Contributor Author

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@invincibleJai
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, invincibleJai, rohitkrai03, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sahil143
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@andrewballantyne
Copy link
Contributor

/retest

1 similar comment
@andrewballantyne
Copy link
Contributor

/retest

@openshift-merge-robot openshift-merge-robot merged commit 72695e0 into openshift:master Aug 1, 2020
@spadgett spadgett added this to the v4.6 milestone Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants